review changes

Signed-off-by: Łukasz Jakimczuk <[email protected]>

Author: ljakimczuk

internal/decryptor/decryptor.go

@@ -573,19 +573,14 @@ func (d *Decryptor) decryptKustomizationSources(visited map[string]struct{}) vis
 				continue
 			}
 
-			u, err := url.Parse(patch.Path)
-			if err != nil {
-				return err
-			}
-
-			if u.IsAbs() {
+			if isRemoteURL(patch.Path) {
 				continue
 			}
 
 			// Determine the format for the patch, defaulting to YAML if not specified.
 			format := formatForPath(patch.Path)
 			// Visit the patch reference and attempt to decrypt it.
-			if err = visitRef(patch.Path, format); err != nil {
+			if err := visitRef(patch.Path, format); err != nil {
 				return err
 			}
 		}
@@ -847,6 +842,17 @@ func recurseKustomizationFiles(root, path string, visit visitKustomization, visi
 	return nil
 }
 
+func isRemoteURL(path string) bool {
+	u, err := url.Parse(path)
+	if err != nil {
+		return false
+	}
+
+	// A remote URL will have a scheme (like "http", "https", "ssh")
+	// AND a host (like "example.com").
+	return u.Scheme != "" && u.Host != ""
+}
+
 // isSOPSEncryptedResource detects if the given resource is a SOPS' encrypted
 // resource by looking for ".sops" and ".sops.mac" fields.
 func isSOPSEncryptedResource(res *resource.Resource) bool {

internal/decryptor/decryptor_test.go

@@ -936,7 +936,7 @@ func TestDecryptor_decryptKustomizationSources(t *testing.T) {
 				},
 				{
 					// this patch gets ignored due to being remote
-					Path: "https:/raw.githubusercontent.com/kubernetes-sigs/kustomize/master/examples/wordpress/patch.yaml",
+					Path: "https://raw.githubusercontent.com/kubernetes-sigs/kustomize/master/examples/wordpress/patch.yaml",
 				},
 			},
 			secretGenerator: []kustypes.SecretArgs{