Implement ExternalArtifact reconciliation

Signed-off-by: Stefan Prodan <[email protected]>

Author: stefanprodan

internal/controller/helmrelease_controller.go

@@ -774,6 +774,9 @@ func (r *HelmReleaseReconciler) getSource(ctx context.Context, obj *v2.HelmRelea
 		if obj.Spec.ChartRef.Kind == sourcev1.OCIRepositoryKind {
 			return r.getSourceFromOCIRef(ctx, obj)
 		}
+		if obj.Spec.ChartRef.Kind == sourcev1.ExternalArtifactKind {
+			return r.getSourceFromExternalArtifact(ctx, obj)
+		}
 		name, namespace = obj.Spec.ChartRef.Name, obj.Spec.ChartRef.Namespace
 		if namespace == "" {
 			namespace = obj.GetNamespace()
@@ -813,6 +816,24 @@ func (r *HelmReleaseReconciler) getSourceFromOCIRef(ctx context.Context, obj *v2
 	return &or, nil
 }
 
+func (r *HelmReleaseReconciler) getSourceFromExternalArtifact(ctx context.Context, obj *v2.HelmRelease) (sourcev1.Source, error) {
+	name, namespace := obj.Spec.ChartRef.Name, obj.Spec.ChartRef.Namespace
+	if namespace == "" {
+		namespace = obj.GetNamespace()
+	}
+	sourceRef := types.NamespacedName{Namespace: namespace, Name: name}
+
+	if err := intacl.AllowsAccessTo(obj, sourcev1.ExternalArtifactKind, sourceRef); err != nil {
+		return nil, err
+	}
+
+	or := sourcev1.ExternalArtifact{}
+	if err := r.Client.Get(ctx, sourceRef, &or); err != nil {
+		return nil, err
+	}
+	return &or, nil
+}
+
 // waitForHistoryCacheSync returns a function that can be used to wait for the
 // cache backing the Kubernetes client to be in sync with the current state of
 // the v2.HelmRelease.
@@ -832,6 +853,13 @@ func (r *HelmReleaseReconciler) waitForHistoryCacheSync(obj *v2.HelmRelease) wai
 }
 
 func isSourceReady(obj sourcev1.Source) (bool, string) {
+	if o, ok := obj.(*sourcev1.ExternalArtifact); ok {
+		if obj.GetArtifact() == nil {
+			return false, fmt.Sprintf("ExternalArtifact '%s/%s' is not ready: does not have an artifact",
+				o.GetNamespace(), o.GetName())
+		}
+		return true, ""
+	}
 	if o, ok := obj.(conditions.Getter); ok {
 		return isReady(o, obj.GetArtifact())
 	}

internal/controller/helmrelease_indexers.go

@@ -105,6 +105,48 @@ func (r *HelmReleaseReconciler) requestsForOCIRepositoryChange(ctx context.Conte
 	return reqs
 }
 
+// requestsForExternalArtifactChange enqueues requests for watched ExternalArtifacts
+// according to the specified index.
+func (r *HelmReleaseReconciler) requestsForExternalArtifactChange(ctx context.Context, o client.Object) []reconcile.Request {
+	or, ok := o.(*sourcev1.ExternalArtifact)
+	if !ok {
+		err := fmt.Errorf("expected an ExternalArtifact, got %T", o)
+		ctrl.LoggerFrom(ctx).Error(err, "failed to get requests for ExternalArtifact change")
+		return nil
+	}
+	// If we do not have an artifact, we have no requests to make
+	if or.GetArtifact() == nil {
+		return nil
+	}
+
+	var list v2.HelmReleaseList
+	if err := r.List(ctx, &list, client.MatchingFields{
+		v2.SourceIndexKey: sourcev1.ExternalArtifactKind + "/" + client.ObjectKeyFromObject(or).String(),
+	}); err != nil {
+		ctrl.LoggerFrom(ctx).Error(err, "failed to list HelmReleases for ExternalArtifact change")
+		return nil
+	}
+
+	var reqs []reconcile.Request
+	for i, hr := range list.Items {
+		// If the HelmRelease is ready and the digest of the artifact equals to the
+		// last attempted revision digest, we should not make a request for this HelmRelease,
+		// likewise if we cannot retrieve the artifact digest.
+		digest := extractDigest(or.GetArtifact().Revision)
+		if digest == "" {
+			ctrl.LoggerFrom(ctx).Error(fmt.Errorf("wrong digest for %T", or), "failed to get requests for ExternalArtifact change")
+			continue
+		}
+
+		if digest == hr.Status.LastAttemptedRevisionDigest {
+			continue
+		}
+
+		reqs = append(reqs, reconcile.Request{NamespacedName: client.ObjectKeyFromObject(&list.Items[i])})
+	}
+	return reqs
+}
+
 // requestsForConfigDependency enqueues requests for watched ConfigMaps or Secrets
 // according to the specified index.
 func (r *HelmReleaseReconciler) requestsForConfigDependency(

internal/controller/helmrelease_manager.go

@@ -133,6 +133,11 @@ func (r *HelmReleaseReconciler) SetupWithManager(ctx context.Context, mgr ctrl.M
 			handler.EnqueueRequestsFromMapFunc(r.requestsForOCIRepositoryChange),
 			builder.WithPredicates(intpredicates.SourceRevisionChangePredicate{}),
 		).
+		Watches(
+			&sourcev1.ExternalArtifact{},
+			handler.EnqueueRequestsFromMapFunc(r.requestsForExternalArtifactChange),
+			builder.WithPredicates(intpredicates.SourceRevisionChangePredicate{}),
+		).
 		WatchesMetadata(
 			&corev1.ConfigMap{},
 			handler.EnqueueRequestsFromMapFunc(r.requestsForConfigDependency(indexConfigMap)),