Skip to content

Commit 68dc676

Browse files
authored
Merge pull request #1000 from hoffimar/deprecations
Move 'Deprecated' comments to own paragraph
2 parents bd9fad5 + 0887009 commit 68dc676

File tree

5 files changed

+20
-4
lines changed

5 files changed

+20
-4
lines changed

api/v2/helmrelease_types.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1045,11 +1045,13 @@ type HelmReleaseStatus struct {
10451045

10461046
// LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
10471047
// reconciliation attempt.
1048+
//
10481049
// Deprecated: Use LastAttemptedConfigDigest instead.
10491050
// +optional
10501051
LastAttemptedValuesChecksum string `json:"lastAttemptedValuesChecksum,omitempty"`
10511052

10521053
// LastReleaseRevision is the revision of the last successful Helm release.
1054+
//
10531055
// Deprecated: Use History instead.
10541056
// +optional
10551057
LastReleaseRevision int `json:"lastReleaseRevision,omitempty"`

api/v2beta1/helmrelease_types.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1205,6 +1205,7 @@ func (in *HelmRelease) SetConditions(conditions []metav1.Condition) {
12051205
}
12061206

12071207
// GetStatusConditions returns a pointer to the Status.Conditions slice.
1208+
//
12081209
// Deprecated: use GetConditions instead.
12091210
func (in *HelmRelease) GetStatusConditions() *[]metav1.Condition {
12101211
return &in.Status.Conditions

api/v2beta2/helmrelease_types.go

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,13 @@ type Kustomize struct {
5252
Patches []kustomize.Patch `json:"patches,omitempty"`
5353

5454
// Strategic merge patches, defined as inline YAML objects.
55+
//
5556
// Deprecated: use Patches instead.
5657
// +optional
5758
PatchesStrategicMerge []apiextensionsv1.JSON `json:"patchesStrategicMerge,omitempty"`
5859

5960
// JSON 6902 patches, defined as inline YAML objects.
61+
//
6062
// Deprecated: use Patches instead.
6163
// +optional
6264
PatchesJSON6902 []kustomize.JSON6902Patch `json:"patchesJson6902,omitempty"`
@@ -1011,6 +1013,7 @@ type HelmReleaseStatus struct {
10111013

10121014
// LastAppliedRevision is the revision of the last successfully applied
10131015
// source.
1016+
//
10141017
// Deprecated: the revision can now be found in the History.
10151018
// +optional
10161019
LastAppliedRevision string `json:"lastAppliedRevision,omitempty"`
@@ -1028,11 +1031,13 @@ type HelmReleaseStatus struct {
10281031

10291032
// LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
10301033
// reconciliation attempt.
1034+
//
10311035
// Deprecated: Use LastAttemptedConfigDigest instead.
10321036
// +optional
10331037
LastAttemptedValuesChecksum string `json:"lastAttemptedValuesChecksum,omitempty"`
10341038

10351039
// LastReleaseRevision is the revision of the last successful Helm release.
1040+
//
10361041
// Deprecated: Use History instead.
10371042
// +optional
10381043
LastReleaseRevision int `json:"lastReleaseRevision,omitempty"`
@@ -1266,6 +1271,7 @@ func (in *HelmRelease) SetConditions(conditions []metav1.Condition) {
12661271
}
12671272

12681273
// GetStatusConditions returns a pointer to the Status.Conditions slice.
1274+
//
12691275
// Deprecated: use GetConditions instead.
12701276
func (in *HelmRelease) GetStatusConditions() *[]metav1.Condition {
12711277
return &in.Status.Conditions

config/crd/bases/helm.toolkit.fluxcd.io_helmreleases.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1147,6 +1147,7 @@ spec:
11471147
description: |-
11481148
LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
11491149
reconciliation attempt.
1150+
11501151
Deprecated: Use LastAttemptedConfigDigest instead.
11511152
type: string
11521153
lastHandledForceAt:
@@ -1169,6 +1170,7 @@ spec:
11691170
lastReleaseRevision:
11701171
description: |-
11711172
LastReleaseRevision is the revision of the last successful Helm release.
1173+
11721174
Deprecated: Use History instead.
11731175
type: integer
11741176
observedCommonMetadataDigest:
@@ -3021,6 +3023,7 @@ spec:
30213023
patchesJson6902:
30223024
description: |-
30233025
JSON 6902 patches, defined as inline YAML objects.
3026+
30243027
Deprecated: use Patches instead.
30253028
items:
30263029
description: JSON6902Patch contains a JSON6902 patch and
@@ -3117,6 +3120,7 @@ spec:
31173120
patchesStrategicMerge:
31183121
description: |-
31193122
Strategic merge patches, defined as inline YAML objects.
3123+
31203124
Deprecated: use Patches instead.
31213125
items:
31223126
x-kubernetes-preserve-unknown-fields: true
@@ -3626,6 +3630,7 @@ spec:
36263630
description: |-
36273631
LastAppliedRevision is the revision of the last successfully applied
36283632
source.
3633+
36293634
Deprecated: the revision can now be found in the History.
36303635
type: string
36313636
lastAttemptedConfigDigest:
@@ -3662,6 +3667,7 @@ spec:
36623667
description: |-
36633668
LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
36643669
reconciliation attempt.
3670+
36653671
Deprecated: Use LastAttemptedConfigDigest instead.
36663672
type: string
36673673
lastHandledForceAt:
@@ -3683,6 +3689,7 @@ spec:
36833689
lastReleaseRevision:
36843690
description: |-
36853691
LastReleaseRevision is the revision of the last successful Helm release.
3692+
36863693
Deprecated: Use History instead.
36873694
type: integer
36883695
observedGeneration:

docs/api/v2/helm.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1694,8 +1694,8 @@ string
16941694
<td>
16951695
<em>(Optional)</em>
16961696
<p>LastAttemptedValuesChecksum is the SHA1 checksum for the values of the last
1697-
reconciliation attempt.
1698-
Deprecated: Use LastAttemptedConfigDigest instead.</p>
1697+
reconciliation attempt.</p>
1698+
<p>Deprecated: Use LastAttemptedConfigDigest instead.</p>
16991699
</td>
17001700
</tr>
17011701
<tr>
@@ -1707,8 +1707,8 @@ int
17071707
</td>
17081708
<td>
17091709
<em>(Optional)</em>
1710-
<p>LastReleaseRevision is the revision of the last successful Helm release.
1711-
Deprecated: Use History instead.</p>
1710+
<p>LastReleaseRevision is the revision of the last successful Helm release.</p>
1711+
<p>Deprecated: Use History instead.</p>
17121712
</td>
17131713
</tr>
17141714
<tr>

0 commit comments

Comments
 (0)