Return not founf when project slice is empty

souleb · souleb · commit c2f9c5cb9991 · 2022-01-24T16:05:41.000+01:00
If implemented this will guard against index out of range errors.

Signed-off-by: Soule BA &lt;soule@weave.works&gt;
diff --git a/stash/projects.go b/stash/projects.go
@@ -168,6 +168,10 @@ func (s *ProjectsService) Get(ctx context.Context, projectName string) (*Project
 		return nil, fmt.Errorf("get project failed, unable to unmarshal repository list json: %w", err)
 	}
 
+	if len(p.Projects) == 0 {
+		return nil, ErrNotFound
+	}
+
 	p.Projects[0].Session.set(resp)
 	return p.Projects[0], nil
 

Original file line number	Diff line number	Diff line change
`@@ -168,6 +168,10 @@ func (s ProjectsService) Get(ctx context.Context, projectName string) (Project`
`168`	`168`	`return nil, fmt.Errorf("get project failed, unable to unmarshal repository list json: %w", err)`
`169`	`169`	`}`
`170`	`170`
	`171`	`+ if len(p.Projects) == 0 {`
	`172`	`+ return nil, ErrNotFound`
	`173`	`+ }`
	`174`	`+`
`171`	`175`	`p.Projects[0].Session.set(resp)`
`172`	`176`	`return p.Projects[0], nil`
`173`	`177`