GitHub usernames are case-insensitive but case preserving. This fixes the issue where setting GITHUB_USER to the same characters in a different case, causes the spurious error: "the specified owner <username> doesn't match the identity associated with the given token"

TonyLovesDevOps · TonyLovesDevOps · commit 051821ea5bd2 · 2024-09-24T15:26:23.000-06:00
Signed-off-by: Tony Worthit &lt;868644+TonyLovesDevOps@users.noreply.github.com&gt;
diff --git a/github/client_repositories_user.go b/github/client_repositories_user.go
@@ -20,6 +20,7 @@ import (
 	"context"
 	"errors"
 	"fmt"
+	"strings"
 
 	"github.com/fluxcd/go-git-providers/gitprovider"
 )
@@ -108,7 +109,8 @@ func (c *UserRepositoriesClient) Create(ctx context.Context,
 		return nil, fmt.Errorf("unable to get owner from API")
 	}
 
-	if ref.GetIdentity() != idRef.GetIdentity() {
+	// GitHub usernames are case insensitive, so compare them with https://pkg.go.dev/strings#EqualFold
+	if strings.EqualFold(ref.GetIdentity(), idRef.GetIdentity()) {
 		return nil, gitprovider.NewErrIncorrectUser(ref.GetIdentity())
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,7 @@ import (`
`20`	`20`	`"context"`
`21`	`21`	`"errors"`
`22`	`22`	`"fmt"`
	`23`	`+ "strings"`
`23`	`24`
`24`	`25`	`"github.com/fluxcd/go-git-providers/gitprovider"`
`25`	`26`	`)`
`@@ -108,7 +109,8 @@ func (c *UserRepositoriesClient) Create(ctx context.Context,`
`108`	`109`	`return nil, fmt.Errorf("unable to get owner from API")`
`109`	`110`	`}`
`110`	`111`
`111`		`- if ref.GetIdentity() != idRef.GetIdentity() {`
	`112`	`+ // GitHub usernames are case insensitive, so compare them with https://pkg.go.dev/strings#EqualFold`
	`113`	`+ if strings.EqualFold(ref.GetIdentity(), idRef.GetIdentity()) {`
`112`	`114`	`return nil, gitprovider.NewErrIncorrectUser(ref.GetIdentity())`
`113`	`115`	`}`
`114`	`116`