NotificationController Alerts Github Commit Status Rate Limit Errors

[dmfrey]

I've noticed that my Commit Status alerts are hitting secondary rate limit errors:

{"level":"error","ts":"2025-05-09T19:56:44.251Z","logger":"event-server","msg":"failed to send notification","eventInvolvedObject":{"kind":"Kustomization","namespace":"security","name":"authentik-provision","uid":"635c894b-5b93-45c4-85b4-41343a6276ea",
"apiVersion":"kustomize.toolkit.fluxcd.io/v1","resourceVersion":"536279175"},"Alert":{"name":"github","namespace":"security"},"error":"could not list commit statuses: GET https://api.github.com/repos/.../statuses?per_page=50: 403 You have exceeded a secondary rate limit. Please wait a few minutes before you try again. If you reach out to GitHub Support for help, please include the request ID A14C:2EE03D:258F6:4BB8F:681E5DFA."}          

Does the Alerts API honor the rate limit headers that Github's API responds with?
https://docs.github.com/en/rest/using-the-rest-api/troubleshooting-the-rest-api?apiVersion=2022-11-28#rate-limit-errors

I've check the Github PAT and verified it can read git repos and modify commit status.

[matheuscscp]

Does the Alerts API honor the rate limit headers that Github's API responds with?

Yes: https://github.com/google/go-github/blob/v64.0.0/github/github.go#L989

[stefanprodan]

Instead of listing the commits we could use GetCombinedStatus to avoid rate limits for repos with a large commit history.

[matheuscscp]

Are we listing the commits? From the code it looks like we are listing only the statuses for a specific commit:

	statuses, _, err := g.Client.Repositories.ListStatuses(ctx, g.Owner, g.Repo, rev, opts) // rev is the commit
	if err != nil {
		return fmt.Errorf("could not list commit statuses: %v", err)
	}

And it looks like GetCombinedStatus() also returns a list of *RepoStatus, like ListStatuses():

// CombinedStatus represents the combined status of a repository at a particular reference.
type CombinedStatus struct {
	// State is the combined state of the repository. Possible values are:
	// failure, pending, or success.
	State *string `json:"state,omitempty"`

	Name       *string       `json:"name,omitempty"`
	SHA        *string       `json:"sha,omitempty"`
	TotalCount *int          `json:"total_count,omitempty"`
	Statuses   []*RepoStatus `json:"statuses,omitempty"`

	CommitURL     *string `json:"commit_url,omitempty"`
	RepositoryURL *string `json:"repository_url,omitempty"`
}

[stefanprodan]

Ah right, we had this issue with GitLab, but for GitHub we only select one commit.