Skip to content

Commit 5ad7540

Browse files
authored
Change editor directory files to use PluginLogger (#8372)
Related to #8369 I also attempted to make the flutter.log file viewable in sandbox mode with a generic file path, but this doesn't work for now - I get an empty file. Oddly this file path will work for `idea.log`, but seems to skip some lines. As the note says, this topic needs further investigation to understand how to optimize this part of setup.
1 parent dec96dc commit 5ad7540

File tree

6 files changed

+12
-6
lines changed

6 files changed

+12
-6
lines changed

.idea/runConfigurations/flutter_intellij__runIde_.xml

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/io/flutter/editor/FlutterColors.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import com.intellij.openapi.diagnostic.Logger;
99
import io.flutter.FlutterUtils;
10+
import io.flutter.logging.PluginLogger;
1011
import org.jetbrains.annotations.NotNull;
1112
import org.jetbrains.annotations.Nullable;
1213

@@ -17,7 +18,7 @@
1718
import java.util.Properties;
1819

1920
public class FlutterColors {
20-
private static final @NotNull Logger LOG = Logger.getInstance(FlutterColors.class);
21+
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterColors.class);
2122

2223
public static class FlutterColor {
2324
@NotNull

src/io/flutter/editor/FlutterCupertinoColors.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import com.intellij.openapi.diagnostic.Logger;
99
import io.flutter.FlutterUtils;
10+
import io.flutter.logging.PluginLogger;
1011
import org.jetbrains.annotations.NotNull;
1112
import org.jetbrains.annotations.Nullable;
1213

@@ -17,7 +18,7 @@
1718
import java.util.Properties;
1819

1920
public class FlutterCupertinoColors {
20-
private static final @NotNull Logger LOG = Logger.getInstance(FlutterCupertinoColors.class);
21+
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterCupertinoColors.class);
2122

2223
private static final Properties colors;
2324

src/io/flutter/editor/FlutterCupertinoIcons.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
import com.intellij.openapi.diagnostic.Logger;
99
import com.intellij.openapi.util.IconLoader;
1010
import io.flutter.FlutterUtils;
11+
import io.flutter.logging.PluginLogger;
1112
import org.jetbrains.annotations.NotNull;
1213

1314
import javax.swing.*;
1415
import java.io.IOException;
1516
import java.util.Properties;
1617

1718
public class FlutterCupertinoIcons {
18-
private static final @NotNull Logger LOG = Logger.getInstance(FlutterCupertinoIcons.class);
19+
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterCupertinoIcons.class);
1920

2021
private static final Properties icons;
2122

src/io/flutter/editor/FlutterIconLineMarkerProvider.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import com.jetbrains.lang.dart.util.DartResolveUtil;
3131
import info.debatty.java.stringsimilarity.JaroWinkler;
3232
import io.flutter.FlutterBundle;
33+
import io.flutter.logging.PluginLogger;
3334
import io.flutter.sdk.FlutterSdk;
3435
import io.flutter.sdk.FlutterSdkUtil;
3536
import io.flutter.utils.IconPreviewGenerator;
@@ -49,7 +50,7 @@ public class FlutterIconLineMarkerProvider extends LineMarkerProviderDescriptor
4950

5051
public static final Map<String, Set<String>> KnownPaths = new HashMap<>();
5152
private static final Map<String, String> BuiltInPaths = new HashMap<>();
52-
private static final @NotNull Logger LOG = Logger.getInstance(FlutterIconLineMarkerProvider.class);
53+
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterIconLineMarkerProvider.class);
5354
private static final String MaterialRelativeAssetPath = "/bin/cache/artifacts/material_fonts/MaterialIcons-Regular.otf";
5455
private static final String MaterialRelativeIconsPath = "/packages/flutter/lib/src/material/icons.dart";
5556
private static final String CupertinoRelativeAssetPath = "/assets/CupertinoIcons.ttf";

src/io/flutter/editor/FlutterMaterialIcons.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
import com.intellij.openapi.diagnostic.Logger;
99
import com.intellij.openapi.util.IconLoader;
1010
import io.flutter.FlutterUtils;
11+
import io.flutter.logging.PluginLogger;
1112
import org.jetbrains.annotations.NotNull;
1213

1314
import javax.swing.*;
1415
import java.io.IOException;
1516
import java.util.Properties;
1617

1718
public class FlutterMaterialIcons {
18-
private static final @NotNull Logger LOG = Logger.getInstance(FlutterMaterialIcons.class);
19+
private static final @NotNull Logger LOG = PluginLogger.createLogger(FlutterMaterialIcons.class);
1920

2021
private static final Properties icons;
2122

0 commit comments

Comments
 (0)