Skip to content

Conversation

@edsiper
Copy link
Member

@edsiper edsiper commented Apr 9, 2025

  • Many libraries/dependencies have been updated to use CMake >= 3.20
  • Added a new CMake option FLB_KAFKA to control globally if Kafka library should be included, this has a higher order of precedence compared to FLB_IN_KAFKA and FLB_OUT_KAFKA (default: FLB_KAFKA On)
  • Centos 7: Kafka support has been disabled: librdkafka requires updated OpenSSL that is not available in Centos 7.
  • Packaging: the following packages have been disabled:
    • Ubuntu 16.04
    • Ubuntu 18.04
    • Ubuntu 18.04 Arm64
    • Ubuntu 20.04
    • Ubuntu 20.04 Arm64
    • Raspbian Buster
    • Raspbian Bullseye

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@edsiper edsiper added this to the Fluent Bit v4.0.1 milestone Apr 9, 2025
@edsiper edsiper merged commit 07a8d36 into master Apr 22, 2025
106 of 113 checks passed
@edsiper edsiper deleted the lib-updates-20250407 branch April 22, 2025 14:32
@@ -1,12 +1,12 @@
cmake_minimum_required(VERSION 3.12)
cmake_minimum_required(VERSION 3.20)
Copy link
Contributor

@mabrarov mabrarov Apr 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change requires changes in run_code_analysis.sh script, because lpenz/ghaction-cmake:0.19 docker image (https://hub.docker.com/r/lpenz/ghaction-cmake) used in that script contains older version of CMake:

$ TEST_PRESET=valgrind SKIP_TESTS='flb-rt-out_td flb-it-network' ./run_code_analysis.sh
...
-- Enabling FLB_REGEX since FLB_PARSER requires
CMake Error at lib/cfl/CMakeLists.txt:1 (cmake_minimum_required):
  CMake 3.20 or higher is required.  You are running version 3.18.4


-- Configuring incomplete, errors occurred!
See also "/tmp/source/CMakeFiles/CMakeOutput.log".
::error title=popen::> Error 1 while running cmake . -DFLB_BACKTRACE=Off -DFLB_SHARED_LIB=Off -DFLB_DEBUG=On -DFLB_ALL=On -DFLB_EXAMPLES=Off -DFLB_TESTS_INTERNAL=On -DFLB_TESTS_RUNTIME=On  -DFLB_WITHOUT_flb-rt-out_td=1 -DFLB_WITHOUT_flb-it-network=1
> > Error 1 while running cmake . -DFLB_BACKTRACE=Off -DFLB_SHARED_LIB=Off -DFLB_DEBUG=On -DFLB_ALL=On -DFLB_EXAMPLES=Off -DFLB_TESTS_INTERNAL=On -DFLB_TESTS_RUNTIME=On  -DFLB_WITHOUT_flb-rt-out_td=1 -DFLB_WITHOUT_flb-it-network=1
::endgroup::
+ exit_code=1
+ rm -f /tmp/tmp.u88OHRGpro
+ exit 1

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to #10238 for one of the possible solutions

mabrarov added a commit to mabrarov/fluent-bit that referenced this pull request Apr 22, 2025
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in fluent#10195.

Signed-off-by: Marat Abrarov <[email protected]>
mabrarov added a commit to mabrarov/fluent-bit that referenced this pull request Apr 22, 2025
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in fluent#10195.

Signed-off-by: Marat Abrarov <[email protected]>
mabrarov added a commit to mabrarov/fluent-bit that referenced this pull request Apr 22, 2025
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in fluent#10195.

Signed-off-by: Marat Abrarov <[email protected]>
edsiper pushed a commit that referenced this pull request Apr 22, 2025
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in #10195.

Signed-off-by: Marat Abrarov <[email protected]>
nourdouf pushed a commit to seveas/fluent-bit that referenced this pull request Sep 23, 2025
…of CMake in code analysis shell script to match minimal CMake version requirement after upgrade of libs in fluent#10195.

Signed-off-by: Marat Abrarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants