in_windows_exporter_metrics: add logical_disk collector

[duj4]

Is your feature request related to a problem? Please describe.
There is no metric related to disk_size exposed while using windows_exporter_metrics.

Describe the solution you'd like
Please add metric for logical_disk_size like windows_exporter as below:

# HELP windows_logical_disk_size_bytes Total space in bytes, updates every 10-15 min (LogicalDisk.PercentFreeSpace_Base)
# TYPE windows_logical_disk_size_bytes gauge
windows_logical_disk_size_bytes{volume="C:"} 2.14013313024e+11
windows_logical_disk_size_bytes{volume="D:"} 2.97359376384e+11
windows_logical_disk_size_bytes{volume="E:"} 1.000202043392e+12
windows_logical_disk_size_bytes{volume="HarddiskVolume4"} 6.10271232e+08

Additional context
Fluent-Bit version: 4.0.4
Windows_Exporter: 0.31.0
Platform: Windows 10

[duj4]

Thanks @edsiper and @cosmo0920 for the help, will pause our current upgrade to 4.0.4 from 4.0.1 till the fix is released.

[duj4]

hi @cosmo0920 ,

Besides windows_logical_disk_size_bytes, we found the metrics below also missed in current windows_exporter_metrics:

windows_cache_async_copy_reads_total
windows_cache_async_data_maps_total
windows_cache_async_fast_reads_total
windows_cache_async_mdl_reads_total
windows_cache_async_pin_reads_total
windows_cache_copy_read_hits_total
windows_cache_copy_reads_total
windows_cache_data_flushes_total
windows_cache_data_flush_pages_total
windows_cache_data_map_hits_percent
windows_cache_data_map_pins_total
windows_cache_data_maps_total
windows_cache_dirty_pages
windows_cache_dirty_page_threshold
windows_cache_fast_read_not_possibles_total
windows_cache_fast_read_resource_misses_total
windows_cache_fast_reads_total
windows_cache_lazy_write_flushes_total
windows_cache_laze_write_pages_total
windows_cache_mdl_read_hits_total
windows_cache_mdl_reads_total
windows_cache_pin_read_hits_total
windows_cache_pin_reads_total
windows_cache_read_aheads_total
windows_cache_sync_copy_reads_total
windows_cache_sync_data_maps_total
windows_cache_sync_fast_reads_total
windows_cache_sync_mdl_reads_total
windows_cache_sync_pin_reads_total
windows_cpu_processor_mperf_total
windows_cpu_processor_privileged_utility_total
windows_cpu_processor_rtc_total
windows_cpu_processor_utility_total
windows_exporter_build_info
windows_exporter_collector_duration_seconds
windows_exporter_collector_success
windows_exporter_collector_timeout
windows_exporter_perflib_snapshot_duration_seconds
windows_logical_disk_avg_read_requests_queued
windows_logical_disk_avg_write_requests_queued
windows_memory_pool_paged_allocs_total
windows_net_oputput_queue_length_packets
windows_os_paging_free_bytes
windows_os_paging_limit_bytes
windows_tcp_connection_failure_total
windows_tcp_connections_active_total
windows_tcp_connections_established
windows_tcp_connections_passive_total
windows_tcp_connections_reset_total
windows_tcp_segments_received_total
windows_tcp_segments_retransmitted_total
windows_tcp_segments_sent_total
windows_tcp_segments_total

It would be much appreciated if you could help add them in as well.

Thanks.

[cosmo0920]

I took a look for the missing metrics but I found that windows_exporter uses some sort of Windows API to obtain metrics that is not listed in perflibs. So, we'll take a look on it.

[duj4]

@cosmo0920 Thanks for the update.

[cosmo0920]

In #10601, I implemented as follows:

windows_cache_async_copy_reads_total
windows_cache_async_data_maps_total
windows_cache_async_fast_reads_total
windows_cache_async_mdl_reads_total
windows_cache_async_pin_reads_total
windows_cache_copy_read_hits_total
windows_cache_copy_reads_total
windows_cache_data_flushes_total
windows_cache_data_flush_pages_total
windows_cache_data_map_hits_percent
windows_cache_data_map_pins_total
windows_cache_data_maps_total
windows_cache_dirty_pages
windows_cache_dirty_page_threshold
windows_cache_fast_read_not_possibles_total
windows_cache_fast_read_resource_misses_total
windows_cache_fast_reads_total
windows_cache_lazy_write_flushes_total
windows_cache_laze_write_pages_total
windows_cache_mdl_read_hits_total
windows_cache_mdl_reads_total
windows_cache_pin_read_hits_total
windows_cache_pin_reads_total
windows_cache_read_aheads_total
windows_cache_sync_copy_reads_total
windows_cache_sync_data_maps_total
windows_cache_sync_fast_reads_total
windows_cache_sync_mdl_reads_total
windows_cache_sync_pin_reads_total
windows_logical_disk_avg_read_requests_queued
windows_logical_disk_avg_write_requests_queued
windows_memory_pool_paged_allocs_total
windows_net_output_queue_length_packets
windows_paging_file_free_bytes
windows_paging_file_limit_bytes
windows_tcp_connection_failure_total
windows_tcp_connections_active_total
windows_tcp_connections_established
windows_tcp_connections_passive_total
windows_tcp_connections_reset_total
windows_tcp_segments_received_total
windows_tcp_segments_retransmitted_total
windows_tcp_segments_sent_total
windows_tcp_segments_total
windows_cpu_processor_mperf_total
windows_cpu_processor_privileged_utility_total
windows_cpu_processor_rtc_total
windows_cpu_processor_utility_total

But the following are exporter itself metrics:

windows_exporter_build_info
windows_exporter_collector_duration_seconds
windows_exporter_collector_success
windows_exporter_collector_timeout
windows_exporter_perflib_snapshot_duration_seconds

So, we might not want to implement in windows_exporter_metrics.
buildinfo could be provide useful information.

[cosmo0920]

Done in #10601.