wip

Signed-off-by: Eduardo Silva <[email protected]>

Author: edsiper

src/cio_file.c

@@ -1135,6 +1135,12 @@ int cio_file_sync(struct cio_chunk *ch)
         return 0;
     }
 
+    /* Check if file is mapped before accessing cf->map */
+    /* This must be checked before accessing cf->map in finalize_checksum() */
+    if (!cio_file_native_is_mapped(cf)) {
+        return -1;
+    }
+
     if (cf->synced == CIO_TRUE) {
         return 0;
     }

tests/fs_windows.c

@@ -236,12 +236,15 @@ static void test_win32_sync_without_map()
     TEST_CHECK(cio_chunk_is_up(chunk) == CIO_FALSE);
     printf("Verified: chunk is down (not mapped)\n");
 
+    /* Set synced flag to FALSE to force sync path (since cio_file_down syncs before unmapping) */
+    cf->synced = CIO_FALSE;
+
     /* Try to sync without mapping using public API */
-    /* On Windows, cio_file_native_sync (called by cio_file_sync) should check if mapped first */
+    /* cio_file_sync should check if file is mapped before accessing cf->map */
     printf("Attempting sync on unmapped file using cio_file_sync()...\n");
-    printf("cio_file_sync() internally calls cio_file_native_sync() which should validate mapping\n");
+    printf("cio_file_sync() should check if mapped before accessing cf->map\n");
 
-    /* Use public API to sync - this internally calls cio_file_native_sync */
+    /* Use public API to sync - this should fail because file is not mapped */
     ret = cio_file_sync(chunk);
     printf("Result of sync without map: %d (expected: -1 for error)\n", ret);