Fix arrow curvature in bent sources/monitors

Signed-off-by: Lucas Heitzmann Gabrielli <[email protected]>

Author: lucas-flexcompute

CHANGELOG.md

@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed scaling for adjoint sources when differentiating with respect to `FieldData` to account for the mesh size of the monitor and thus the created source. This aligns adjoint gradient magnitudes with numerical finite difference gradients for field data.
 - Warn when mode solver pml covers a significant portion of the mode plane.
 - TFSF server errors related to the auxiliary plane wave source that would previously happen on the server are now caught upon simulation creation.
+- Opposite arrow curvature for mode sources and monitors with non-zero bendind radius when plotted in the figure's Y axis.
 
 ### Changed
 - `num_freqs` in Gaussian beam type sources limited to 20, which should besufficient for all cases.

tidy3d/components/monitor.py

@@ -364,14 +364,19 @@ def plot(
         kwargs_alpha = patch_kwargs.get("alpha")
         arrow_alpha = ARROW_ALPHA if kwargs_alpha is None else kwargs_alpha
 
+        bend_radius = self.mode_spec.bend_radius
+        # Curvature has to be reversed because of ploting coordinates
+        if (self.normal_axis, self._bend_axis) in [(1, 2), (2, 0), (2, 1)]:
+            bend_radius = -bend_radius
+
         # and then add an arrow using the direction comuputed from `_dir_arrow`.
         ax = self._plot_arrow(
             x=x,
             y=y,
             z=z,
             ax=ax,
             direction=self._dir_arrow,
-            bend_radius=self.mode_spec.bend_radius,
+            bend_radius=bend_radius,
             bend_axis=self._bend_axis,
             color=ARROW_COLOR_MONITOR,
             alpha=arrow_alpha,

tidy3d/components/source/base.py

@@ -86,9 +86,15 @@ def plot(
         if self._dir_vector is not None:
             bend_radius = None
             bend_axis = None
-            if hasattr(self, "mode_spec"):
+            if hasattr(self, "mode_spec") and self.mode_spec.bend_radius is not None:
                 bend_radius = self.mode_spec.bend_radius
                 bend_axis = self._bend_axis
+                sign = 1 if self.direction == "+" else -1
+                # Curvature has to be reversed because of ploting coordinates
+                if (self.size.index(0), bend_axis) in [(1, 2), (2, 0), (2, 1)]:
+                    bend_radius *= -sign
+                else:
+                    bend_radius *= sign
 
             ax = self._plot_arrow(
                 x=x,