Skip to content

Commit ffa458a

Browse files
TheEvilSkeletonsmcv
authored andcommitted
settings: Rename namespace parameters to namespace_
`namespace` is reserved in C++, which causes it to break the Qt test app. This will be useful in the next commit, which will expose `settings.h`.
1 parent 8cfddc0 commit ffa458a

File tree

2 files changed

+21
-21
lines changed

2 files changed

+21
-21
lines changed

libportal/settings.c

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ xdp_settings_class_init (XdpSettingsClass *klass)
7979
/**
8080
* XdpSettings::changed:
8181
* @settings: the [class@Settings] object
82-
* @namespace: the value namespace
82+
* @namespace_: the value namespace
8383
* @key: the value key
8484
* @value: the value
8585
*
@@ -136,22 +136,22 @@ settings_changed (GDBusConnection *bus,
136136
/**
137137
* xdp_settings_read_uint:
138138
* @settings: the [class@Settings] object.
139-
* @namespace: the namespace of the value.
139+
* @namespace_: the namespace of the value.
140140
* @key: the key of the value.
141141
* @cancellable: a GCancellable or NULL.
142142
* @error: return location for error or NULL.
143143
*
144-
* Read a setting value as unsigned int within @namespace, with @key.
144+
* Read a setting value as unsigned int within @namespace_, with @key.
145145
*
146146
* Returns: the uint value, or 0 if not found or not
147147
* the right type. If @error is not NULL, then the error is returned.
148148
*/
149149
guint32
150-
xdp_settings_read_uint (XdpSettings *settings, const char *namespace, const char *key, GCancellable *cancellable, GError **error)
150+
xdp_settings_read_uint (XdpSettings *settings, const char *namespace_, const char *key, GCancellable *cancellable, GError **error)
151151
{
152152
g_autoptr(GVariant) value = NULL;
153153

154-
value = xdp_settings_read_value (settings, namespace, key, cancellable, error);
154+
value = xdp_settings_read_value (settings, namespace_, key, cancellable, error);
155155
if (value)
156156
{
157157
if (g_variant_is_of_type (value, G_VARIANT_TYPE_UINT32))
@@ -165,22 +165,22 @@ xdp_settings_read_uint (XdpSettings *settings, const char *namespace, const char
165165
/**
166166
* xdp_settings_read_string:
167167
* @settings: the [class@Settings] object.
168-
* @namespace: the namespace of the value.
168+
* @namespace_: the namespace of the value.
169169
* @key: the key of the value.
170170
* @cancellable: a GCancellable or NULL.
171171
* @error: return location for error or NULL.
172172
*
173-
* Read a setting value as unsigned int within @namespace, with @key.
173+
* Read a setting value as unsigned int within @namespace_, with @key.
174174
*
175175
* Returns: (transfer full): the stringint value, or NULL if not found or not
176176
* the right type. If @error is not NULL, then the error is returned.
177177
*/
178178
char *
179-
xdp_settings_read_string (XdpSettings *settings, const char *namespace, const char *key, GCancellable *cancellable, GError **error)
179+
xdp_settings_read_string (XdpSettings *settings, const char *namespace_, const char *key, GCancellable *cancellable, GError **error)
180180
{
181181
g_autoptr(GVariant) value = NULL;
182182

183-
value = xdp_settings_read_value (settings, namespace, key, cancellable, error);
183+
value = xdp_settings_read_value (settings, namespace_, key, cancellable, error);
184184
if (value)
185185
{
186186
if (g_variant_is_of_type (value, G_VARIANT_TYPE_STRING))
@@ -194,14 +194,14 @@ xdp_settings_read_string (XdpSettings *settings, const char *namespace, const ch
194194
/**
195195
* xdp_settings_read:
196196
* @settings: the [class@Settings] object.
197-
* @namespace: the namespace of the value.
197+
* @namespace_: the namespace of the value.
198198
* @key: the key of the value.
199199
* @cancellable: a GCancellable or NULL.
200200
* @error: return location for error or NULL.
201201
* @format: a #GVariant format string
202202
* @...: arguments as per @format
203203
*
204-
* Read a setting value within @namespace, with @key.
204+
* Read a setting value within @namespace_, with @key.
205205
*
206206
* A convenience function that combines xdp_settings_read_value() with
207207
* g_variant_get().
@@ -210,12 +210,12 @@ xdp_settings_read_string (XdpSettings *settings, const char *namespace, const ch
210210
* returned.
211211
*/
212212
void
213-
xdp_settings_read (XdpSettings *settings, const char *namespace, const gchar *key, GCancellable *cancellable, GError **error, const gchar *format, ...)
213+
xdp_settings_read (XdpSettings *settings, const char *namespace_, const gchar *key, GCancellable *cancellable, GError **error, const gchar *format, ...)
214214
{
215215
g_autoptr(GVariant) value = NULL;
216216
va_list ap;
217217

218-
value = xdp_settings_read_value (settings, namespace, key, cancellable, error);
218+
value = xdp_settings_read_value (settings, namespace_, key, cancellable, error);
219219
if (value)
220220
{
221221
va_start (ap, format);
@@ -227,18 +227,18 @@ xdp_settings_read (XdpSettings *settings, const char *namespace, const gchar *ke
227227
/**
228228
* xdp_settings_read_value:
229229
* @settings: the [class@Settings] object.
230-
* @namespace: the namespace of the value.
230+
* @namespace_: the namespace of the value.
231231
* @key: the key of the value.
232232
* @cancellable: a GCancellable or NULL.
233233
* @error: return location for error or NULL.
234234
*
235-
* Read a setting value within @namespace, with @key.
235+
* Read a setting value within @namespace_, with @key.
236236
*
237237
* Returns: (transfer full): the value, or %NULL if not
238238
* found. If @error is not NULL, then the error is returned.
239239
*/
240240
GVariant *
241-
xdp_settings_read_value (XdpSettings *settings, const char *namespace, const char *key, GCancellable *cancellable, GError **error)
241+
xdp_settings_read_value (XdpSettings *settings, const char *namespace_, const char *key, GCancellable *cancellable, GError **error)
242242
{
243243
g_autoptr(GVariant) ret = NULL;
244244
g_autoptr(GVariant) inner = NULL;
@@ -248,7 +248,7 @@ xdp_settings_read_value (XdpSettings *settings, const char *namespace, const cha
248248
PORTAL_OBJECT_PATH,
249249
SETTINGS_INTERFACE,
250250
"ReadOne",
251-
g_variant_new ("(ss)", namespace, key),
251+
g_variant_new ("(ss)", namespace_, key),
252252
NULL,
253253
G_DBUS_CALL_FLAGS_NONE,
254254
5000,

libportal/settings.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,20 +32,20 @@ XDP_PUBLIC
3232
G_DECLARE_FINAL_TYPE (XdpSettings, xdp_settings, XDP, SETTINGS, GObject)
3333

3434
XDP_PUBLIC
35-
GVariant *xdp_settings_read_value (XdpSettings *settings, const char *namespace, const char *key, GCancellable *cancellable, GError **error);
35+
GVariant *xdp_settings_read_value (XdpSettings *settings, const char *namespace_, const char *key, GCancellable *cancellable, GError **error);
3636

3737
XDP_PUBLIC
3838
void
39-
xdp_settings_read (XdpSettings *settings, const char *namespace,
39+
xdp_settings_read (XdpSettings *settings, const char *namespace_,
4040
const gchar *key,
4141
GCancellable *cancellable, GError **error,
4242
const gchar *format, ...);
4343

4444
XDP_PUBLIC
45-
guint xdp_settings_read_uint (XdpSettings *settings, const char *namespace, const char *key, GCancellable *cancellable, GError **error);
45+
guint xdp_settings_read_uint (XdpSettings *settings, const char *namespace_, const char *key, GCancellable *cancellable, GError **error);
4646

4747
XDP_PUBLIC
48-
char *xdp_settings_read_string (XdpSettings *settings, const char *namespace, const char *key, GCancellable *cancellable, GError **error);
48+
char *xdp_settings_read_string (XdpSettings *settings, const char *namespace_, const char *key, GCancellable *cancellable, GError **error);
4949

5050
XDP_PUBLIC
5151
GVariant *xdp_settings_read_all_values (XdpSettings *settings, const char *const *namespaces, GCancellable *cancellable, GError **error);

0 commit comments

Comments
 (0)