builder: Export sources extension to repo #226
Conversation
bbhtt
force-pushed
the
bbhtt/bundle-sources
branch
2 times, most recently
from
b6c3682 to
6e850f7
Compare
|
ping @bilelmoussaoui |
| `--default-branch=${branch}`, | ||
| `--arch=${config.arch}` | ||
| ] | ||
| if (config.arch === 'x86_64' && config.bundleSources !== false) { |
There was a problem hiding this comment.
Nothing says in the readme that this would only be enabled for x86_64
There was a problem hiding this comment.
I feel like this arch condition should be removed and you could set bundle-source: ${arch} == 'x86_64'` or so?
There was a problem hiding this comment.
No we don't want everyone uploading sources from both arches to Flathub.
There was a problem hiding this comment.
But what if someone wants to build an aarch64 only app? We can potentially add a flathub mode that enforces specific configs for it or something like that
There was a problem hiding this comment.
A flathub mode won't prevent if people can tweak some action options and do it anyway.
bbhtt
force-pushed
the
bbhtt/bundle-sources
branch
from
6e850f7 to
caba4a6
Compare
|
Patched flatpak-builder, should've done that earlier actually... |
A new v6 tag should be created if this is merged.