Skip to content

Keep GPBFT disabled until the node actually starts participating. #650

@Stebalien

Description

@Stebalien
Member

Until some storageminer process calls F3Participate, we should passively follow F3 via the finality certificate exchange instead of via pubsub to avoid wasting bandwidth. This way:

  1. Pure clients can save a lot of bandwidth.
  2. SPs can save bandwidth by delegating all F3 operations to a single client.

Activity

masih

masih commented on Oct 8, 2024

@masih
Member

This would probably touch some of #588? Would be nice to knock that one out too.

Stebalien

Stebalien commented on Oct 8, 2024

@Stebalien
MemberAuthor

It should be mostly orthogonal, but I agree.

Stebalien

Stebalien commented on Oct 8, 2024

@Stebalien
MemberAuthor

Two options:

  1. Abstract over this in lotus and don't start the inner F3 module until we need it. That'll lead to a cleaner solution in this repo, but we'll also have some duplicate setup code (need a certstore, certserve, certsub, etc.).
  2. Change F3.MessagesToSign to something like F3.Participate(), lazily starting the runner on-demand. Honestly, we don't really need a way to stop participating.

Personally, I'm leaning towards option 2. It's a bit of work in this repo, but not much.

masih

masih commented on Oct 8, 2024

@masih
Member

Option 2 sgtm too.

BigLep

BigLep commented on Apr 1, 2025

@BigLep
Member

Per internal 2025-03-28 slack conversation, it wasn't deemed critical to make it an immediate followup/cleanup after F3 activation. As a result, I have reassigned its milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Todo

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @BigLep@masih@Stebalien@Kubuxu@rjan90

        Issue actions

          Keep GPBFT disabled until the node actually starts participating. · Issue #650 · filecoin-project/go-f3