deploy: retry registry logout on flaky network#10
Merged
Conversation
deploy_logout_from_registry was the only of the four registry/network operations not wrapped by gpd_retry. Add the same wrapper as login, pull, push, and GeoIP download — retries up to --retries (default 3) times with exponential backoff (1s, 2s, 4s). Update README's -r/--retries description and CHANGELOG [Unreleased] to list logout alongside the others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy_logout_from_registrywas the only of the four registry/network operations not wrapped bygpd_retry. Add the same wrapper as login, pull, push, and GeoIP download — retries up to--retries(default 3) times with exponential backoff (1s, 2s, 4s).Test plan
bash -ncleanbats tests/bats/— 46/46 still green