-
Notifications
You must be signed in to change notification settings - Fork 56
Core udmi services integration stage two #1204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core udmi services integration stage two #1204
Conversation
…e' into Core-UDMI-Services-Integration-stage-two
…le. Update broker to use the mosquitto container
…e' into Core-UDMI-Services-Integration-stage-two
|
@nataliakenrick please take the latest pull from master. |
…p. Set restart: always for all containers
…thub.com/nataliakenrick/udmi into Core-UDMI-Services-Integration-stage-two
bridgehead/README.md
Outdated
| - etcd server | ||
| - udmis service | ||
| - validator (registrar) tool | ||
| - pubber tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pubber is a tool, we don't need this as a service. For now, any specific reason of having pubber as a service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I included it to help users easily test the local setup.
Since it doesn't need to run as a permanent service, I can go ahead and remove the service definition. Let me know if that works for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's remove it from the service definition for now as it is more of a tool.
bridgehead/README.md
Outdated
| - Mosquitto broker | ||
| - etcd server | ||
| - udmis service | ||
| - validator (registrar) tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Validator and Registrar, are two different things. Validator is something which can run in the background continuously and validate the messages coming are UDMI compliant or not (so a service), but Registrar is kind of tool which is suppose to run for some time, and after it's work is done, it stops (so, more of a tool) which can be executed from inside the validator container as well.
bridgehead/README.md
Outdated
| - etcd server | ||
| - udmis service | ||
| - validator (registrar) tool | ||
| - pubber tool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's remove it from the service definition for now as it is more of a tool.
|
|
||
| Start pubber container: `sudo docker run -d --rm --name pubber -v $(realpath udmi_site_model):/root/site_model ghcr.io/faucetsdn/udmi:pubber-latest /bin/bash -c "tail -f /dev/null"` | ||
|
|
||
| Run pubber: `sudo docker exec pubber bin/pubber site_model/ //mqtt/<YOUR_HOST_IP> AHU-1 123456` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update this as pubber container will not be there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a separate command; it will create a standalone pubber container for testing, but it isn't part of the Docker Compose. This container can be run on the same machine as the Docker Compose, or on an external machine. Would still like me to remove it/improve the documentation so this is clear?
jainrocks
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes
udmis,etcd, andvalidator(for registrar tool).CTRL_OPTSinetc/mosquitto_ctrl.shto configure the host and port using environment variables ($MQTT_HOST,$MQTT_PORT), defaulting to local values if variables are absent.