Skip to content

Conversation

@nataliakenrick
Copy link
Contributor

Changes

  • New Services: Adds Docker containers for udmis, etcd, and validator (for registrar tool).
  • Documentation: Updated setup instructions to reflect the new Docker Compose environment.
  • Suggestion: Updated the CTRL_OPTS in etc/mosquitto_ctrl.sh to configure the host and port using environment variables ($MQTT_HOST, $MQTT_PORT), defaulting to local values if variables are absent.

@jainrocks
Copy link
Collaborator

@nataliakenrick please take the latest pull from master.

- etcd server
- udmis service
- validator (registrar) tool
- pubber tool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pubber is a tool, we don't need this as a service. For now, any specific reason of having pubber as a service?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I included it to help users easily test the local setup.

Since it doesn't need to run as a permanent service, I can go ahead and remove the service definition. Let me know if that works for you.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's remove it from the service definition for now as it is more of a tool.

- Mosquitto broker
- etcd server
- udmis service
- validator (registrar) tool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validator and Registrar, are two different things. Validator is something which can run in the background continuously and validate the messages coming are UDMI compliant or not (so a service), but Registrar is kind of tool which is suppose to run for some time, and after it's work is done, it stops (so, more of a tool) which can be executed from inside the validator container as well.

- etcd server
- udmis service
- validator (registrar) tool
- pubber tool
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's remove it from the service definition for now as it is more of a tool.


Start pubber container: `sudo docker run -d --rm --name pubber -v $(realpath udmi_site_model):/root/site_model ghcr.io/faucetsdn/udmi:pubber-latest /bin/bash -c "tail -f /dev/null"`

Run pubber: `sudo docker exec pubber bin/pubber site_model/ //mqtt/<YOUR_HOST_IP> AHU-1 123456`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update this as pubber container will not be there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a separate command; it will create a standalone pubber container for testing, but it isn't part of the Docker Compose. This container can be run on the same machine as the Docker Compose, or on an external machine. Would still like me to remove it/improve the documentation so this is clear?

Copy link
Collaborator

@jainrocks jainrocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jainrocks jainrocks merged commit b36a112 into faucetsdn:master Nov 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants