Skip to content
This repository was archived by the owner on Jun 20, 2025. It is now read-only.

Commit 017348e

Browse files
jrodal98facebook-github-bot
authored andcommitted
dynamically check game type (#2205)
Summary: Pull Request resolved: #2205 ## What - Don't hardcode the game type strings in PC-CLI ## Why - Because it's annoying Reviewed By: joe1234wu, xyguo Differential Revision: D44176952 fbshipit-source-id: e139bd21758b417cabcc0ab0e86895e663cbfa5a
1 parent 679b5c5 commit 017348e

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

fbpcs/private_computation_cli/private_computation_cli.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -222,9 +222,7 @@ def main(argv: Optional[List[str]] = None) -> None:
222222
None,
223223
schema.And(
224224
schema.Use(str.upper),
225-
# TODO(T148164182): try replacing this with "lambda s: any(s == g.value for g in PrivateComputationGameType)"
226-
lambda s: s
227-
in ("LIFT", "ATTRIBUTION", "PRIVATE_ID_DFCA", "ANONYMIZER"),
225+
lambda s: s in (g.value for g in PrivateComputationGameType),
228226
schema.Use(PrivateComputationGameType),
229227
),
230228
),

0 commit comments

Comments
 (0)