Add null check to tryParse boolean (#3783)

* add null check to tryParse boolean

* try fix test

* Update changelog

---------

Co-authored-by: Maxime Mangel <[email protected]>

Author: goswinr

src/Fable.Cli/CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * [Rust] Fixed generic interface implementation types (by @ncave)
 * [Rust] Fixed Dictionary constructor from IEnumerable (by @ncave)
 * [Rust] Fixed Seq.cast support for arrays and lists (by @ncave)
+* [GH-3783](https://github.com/fable-compiler/Fable/pull/3783) [JS/TS] `Boolean.tryParse` should not crash on `null` string (@goswinr)
 
 ### Added
 

src/fable-library-ts/Boolean.ts

@@ -1,10 +1,10 @@
 import { FSharpRef } from "./Types.js"
 
 export function tryParse(str: string, defValue: FSharpRef<boolean>): boolean {
-  if (str.match(/^\s*true\s*$/i)) {
+  if (str != null && str.match(/^\s*true\s*$/i)) {
     defValue.contents = true;
     return true;
-  } else if (str.match(/^\s*false\s*$/i)) {
+  } else if (str != null && str.match(/^\s*false\s*$/i)) {
     defValue.contents = false;
     return true;
   }

tests/Js/Main/ConvertTests.fs

@@ -90,15 +90,21 @@ let tests =
         throwsAnyError (fun () -> Boolean.Parse "falsee")
 
     testCase "System.Boolean.TryParse works" <| fun () ->
+        // expect parse success
         Boolean.TryParse "true" |> equal (true, true)
         Boolean.TryParse "True" |> equal (true, true)
         Boolean.TryParse " true " |> equal (true, true)
         Boolean.TryParse "false" |> equal (true, false)
         Boolean.TryParse "False" |> equal (true, false)
         Boolean.TryParse " false " |> equal (true, false)
 
+        // expect parse failure
         Boolean.TryParse "tru" |> equal (false, false)
         Boolean.TryParse "falsee" |> equal (false, false)
+        Boolean.TryParse  "0"  |> equal (false, false)
+        Boolean.TryParse  ""   |> equal (false, false)
+        Boolean.TryParse  "1"  |> equal (false, false)
+        Boolean.TryParse  null |> equal (false, false)
 
     testCase "System.SByte.Parse works" <| fun () ->
         SByte.Parse("5") |> equal 5y