Skip to content

Commit 31c0c23

Browse files
Added TS(9) support in Exasol VS (#131)
- updated exasol versions to the latest ones - applied generated changes based on the project-keeper:fix to fix security vulnerabilities - added ExaMetadata parameters for several constructors after updating virtual-schema-common-jdbc after updating from version 12.0.0 to 13.0.0 - started to fix the test, which now parses exasol db version from ExaMetadata parameter - fixed unit tests by returning not-null getDatabaseVersion() for exaMetadataMock - updated ubuntu version and exasol database versions in the github workflow - added summary and other sections to changes document - fixed project-keeper findings, which unfortunately don't reflect in a local run - fixed project-keeper verify errors - try to fix the integration tests and some other minor changes - implemented extractTimestampPrecision method and added unit tests for 6 TIMESTAMP example values - fixed Sonar Cloud findings - added parameterized test methods for timestamp values - try to fix integration tests by using timestamp with precision for timestamp type - try to fix integration tests by reverting unnecessary changes and by updating docker exasol db version from 8.24.0 (without timestamp precision support) to 8.34.0 (with timestamp precision support) - added solution to run integration tests locally by adding use case for local environment in getTestHostIpFromInsideExasol - fixed integration tests for timestamp with local timezone by implementing convertTimestamp in ExasolColumnMetadataReader, which is the same as in BaseColumnMetadataReader, only for timestamp with local time zone - not sure about the expected behaviour for test testCastVarcharAsTimestampWithLocalTimezone. Currently it truncates timestamp to microseconds (6 decimal values), therefore timestamps with 7,8 and 9 precision are truncated to timestamp with 6 precision: if it is not expected behaviour, then we need to clarify where and how to fix it - fixed unit tests for timestamps with local zone and with precision - added suggestions from the PR review - fixed the test for 8.29.9 version by implementing supportTimestampPrecision() method and skipping the tests, if the exasol db version doesn't support timestamp precision - fixed sonar cloud code smells - added javadocs comment to testCastVarcharAsTimestampWithCustomPrecision regarding truncation of the decimal digits to 6 for TIMESTAMP(7-9) - fixed testCastVarcharAsTimestampWithCustomPrecision by setting system‐wide default timestamp format to include up to 9 fractional digits (using "ALTER SYSTEM SET NLS_TIMESTAMP_FORMAT = 'YYYY-MM-DD HH24:MI:SS.FF9'") - try to fix integration test testCastVarcharAsTimestampWithCustomPrecision in the github actions by adding accept("TIMESTAMP") - try to fix integration test by adding ALTER SESSION in addition to ALTER SYSTEM - fixed sonar cloud warning - some changes based on the PR review comments - Updated release date in doc/changes/changes_8.0.1.md --------- Co-authored-by: Christoph Pirkl <[email protected]>
1 parent 1c0ec6b commit 31c0c23

38 files changed

+1300
-692
lines changed

.gitattributes

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
SECURITY.md linguist-generated=true
12
dependencies.md linguist-generated=true
23
doc/changes/changelog.md linguist-generated=true
34
pk_generated_parent.pom linguist-generated=true
@@ -9,5 +10,4 @@ pk_generated_parent.pom linguist-genera
910
.github/workflows/release.yml linguist-generated=true
1011
.settings/org.eclipse.jdt.core.prefs linguist-generated=true
1112
.settings/org.eclipse.jdt.ui.prefs linguist-generated=true
12-
.settings/org.eclipse.jdt.core.prefs linguist-generated=true
13-
.settings/org.eclipse.jdt.ui.prefs linguist-generated=true
13+

.github/workflows/broken_links_checker.yml

Lines changed: 31 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/ci-build-next-java.yml

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)