Skip to content

Commit ed4409e

Browse files
dphuang2dphuang2
authored
Aggregated metrics part 10 (#67)
* store page and page size state in globalstate and persist * add loading state * fix mobx warnings * add filtering to table * styling is better * Remove reset filters button and associated functionality from EvaluationTable component * remove too much paddign around filter configuration * optimize a bit * DRY things * Refactor filter operators to eliminate duplicates in getOperatorsForField function * Update styling for SearchableSelect component to improve dropdown positioning * vite build * Remove reset filters button from Dashboard component * vite build * vite build * debounce
1 parent ea2c7c8 commit ed4409e

16 files changed

+879
-381
lines changed

‎vite-app/dist/assets/index-CmEkuH8E.js‎

Lines changed: 0 additions & 93 deletions
This file was deleted.

‎vite-app/dist/assets/index-CmEkuH8E.js.map‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎vite-app/dist/assets/index-CpScNe1P.css‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vite-app/dist/assets/index-DZwKPeo5.css‎

Lines changed: 0 additions & 1 deletion
This file was deleted.

‎vite-app/dist/assets/index-dHlKwEPE.js‎

Lines changed: 93 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vite-app/dist/assets/index-dHlKwEPE.js.map‎

Lines changed: 1 addition & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎vite-app/dist/index.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
66
<title>EP | Log Viewer</title>
77
<link rel="icon" href="/assets/favicon-BkAAWQga.png" />
8-
<script type="module" crossorigin src="/assets/index-CmEkuH8E.js"></script>
9-
<link rel="stylesheet" crossorigin href="/assets/index-DZwKPeo5.css">
8+
<script type="module" crossorigin src="/assets/index-dHlKwEPE.js"></script>
9+
<link rel="stylesheet" crossorigin href="/assets/index-CpScNe1P.css">
1010
</head>
1111
<body>
1212
<div id="root"></div>

‎vite-app/src/App.tsx‎

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,8 @@ const App = observer(() => {
3232

3333
ws.onopen = () => {
3434
console.log("Connected to file watcher");
35-
state.isConnected = true;
35+
state.setConnected(true);
36+
state.setLoading(true); // Set loading when connection opens
3637
reconnectAttemptsRef.current = 0; // Reset reconnect attempts on successful connection
3738
};
3839

@@ -48,18 +49,21 @@ const App = observer(() => {
4849
console.log("initialize_logs", rows);
4950
state.upsertRows(rows);
5051
} else if (update.type === "log") {
52+
state.setLoading(true); // Set loading for individual log updates
5153
const row: EvaluationRow = EvaluationRowSchema.parse(update.row);
5254
console.log("log", row);
5355
state.upsertRows([row]);
5456
}
5557
} catch (error) {
5658
console.error("Failed to parse WebSocket message:", error);
59+
state.setLoading(false); // Clear loading state on error
5760
}
5861
};
5962

6063
ws.onclose = (event) => {
6164
console.log("Disconnected from file watcher", event.code, event.reason);
62-
state.isConnected = false;
65+
state.setConnected(false);
66+
state.setLoading(false); // Clear loading state on disconnect
6367

6468
// Attempt to reconnect if not a normal closure
6569
if (
@@ -72,7 +76,8 @@ const App = observer(() => {
7276

7377
ws.onerror = (error) => {
7478
console.error("WebSocket error:", error);
75-
state.isConnected = false;
79+
state.setConnected(false);
80+
state.setLoading(false); // Clear loading state on error
7681
};
7782
};
7883

@@ -99,6 +104,7 @@ const App = observer(() => {
99104

100105
// Manual refresh handler
101106
const handleManualRefresh = () => {
107+
state.setLoading(true); // Set loading when manually refreshing
102108
if (wsRef.current) {
103109
try {
104110
wsRef.current.onclose = null; // Prevent triggering reconnect logic

0 commit comments

Comments
 (0)