Swap strong alias with weak function

Existing state confuses LLVM CFI. Probably we can find a fix in CFI
llvm/llvm-project#150070.

However, this workaround seems less confusing for humans as well,
and makes code compatible with existing compilers.

Before the patch the code preserved weak function
body even if weak function was overridden with strong function.

With the patch version we will override alias, which is more conventional.

PiperOrigin-RevId: 786135294

Author: xnnpack-bot

src/legacy-api.c

@@ -20,36 +20,35 @@
 #include "threadpool-common.h"
 #include "threadpool-utils.h"
 
-PTHREADPOOL_WEAK void pthreadpool_compute_1d(pthreadpool_t threadpool,
-                                             pthreadpool_function_1d_t function,
-                                             void* argument, size_t range) {
+void PTHREADPOOL_IMPL(pthreadpool_compute_1d)(
+    pthreadpool_t threadpool, pthreadpool_function_1d_t function,
+    void* argument, size_t range) {
   pthreadpool_parallelize_1d(threadpool, (pthreadpool_task_1d_t)function,
                              argument, range, 0 /* flags */);
 }
 
-PTHREADPOOL_PRIVATE_IMPL(pthreadpool_compute_1d)
+PTHREADPOOL_WEAK_ALIAS(pthreadpool_compute_1d)
 
-PTHREADPOOL_WEAK void pthreadpool_compute_1d_tiled(
+void PTHREADPOOL_IMPL(pthreadpool_compute_1d_tiled)(
     pthreadpool_t threadpool, pthreadpool_function_1d_tiled_t function,
     void* argument, size_t range, size_t tile) {
   pthreadpool_parallelize_1d_tile_1d(threadpool,
                                      (pthreadpool_task_1d_tile_1d_t)function,
                                      argument, range, tile, 0 /* flags */);
 }
 
-PTHREADPOOL_PRIVATE_IMPL(pthreadpool_compute_1d_tiled)
+PTHREADPOOL_WEAK_ALIAS(pthreadpool_compute_1d_tiled)
 
-PTHREADPOOL_WEAK void pthreadpool_compute_2d(pthreadpool_t threadpool,
-                                             pthreadpool_function_2d_t function,
-                                             void* argument, size_t range_i,
-                                             size_t range_j) {
+void PTHREADPOOL_IMPL(pthreadpool_compute_2d)(
+    pthreadpool_t threadpool, pthreadpool_function_2d_t function,
+    void* argument, size_t range_i, size_t range_j) {
   pthreadpool_parallelize_2d(threadpool, (pthreadpool_task_2d_t)function,
                              argument, range_i, range_j, 0 /* flags */);
 }
 
-PTHREADPOOL_PRIVATE_IMPL(pthreadpool_compute_2d)
+PTHREADPOOL_WEAK_ALIAS(pthreadpool_compute_2d)
 
-PTHREADPOOL_WEAK void pthreadpool_compute_2d_tiled(
+void PTHREADPOOL_IMPL(pthreadpool_compute_2d_tiled)(
     pthreadpool_t threadpool, pthreadpool_function_2d_tiled_t function,
     void* argument, size_t range_i, size_t range_j, size_t tile_i,
     size_t tile_j) {
@@ -58,7 +57,7 @@ PTHREADPOOL_WEAK void pthreadpool_compute_2d_tiled(
       range_j, tile_i, tile_j, 0 /* flags */);
 }
 
-PTHREADPOOL_PRIVATE_IMPL(pthreadpool_compute_2d_tiled)
+PTHREADPOOL_WEAK_ALIAS(pthreadpool_compute_2d_tiled)
 
 struct compute_3d_tiled_context {
   pthreadpool_function_3d_tiled_t function;
@@ -94,7 +93,7 @@ static void compute_3d_tiled(const struct compute_3d_tiled_context* context,
                     tile_j, tile_k);
 }
 
-PTHREADPOOL_WEAK void pthreadpool_compute_3d_tiled(
+void PTHREADPOOL_IMPL(pthreadpool_compute_3d_tiled)(
     pthreadpool_t threadpool, pthreadpool_function_3d_tiled_t function,
     void* argument, size_t range_i, size_t range_j, size_t range_k,
     size_t tile_i, size_t tile_j, size_t tile_k) {
@@ -131,7 +130,7 @@ PTHREADPOOL_WEAK void pthreadpool_compute_3d_tiled(
   }
 }
 
-PTHREADPOOL_PRIVATE_IMPL(pthreadpool_compute_3d_tiled)
+PTHREADPOOL_WEAK_ALIAS(pthreadpool_compute_3d_tiled)
 
 struct compute_4d_tiled_context {
   pthreadpool_function_4d_tiled_t function;
@@ -176,7 +175,7 @@ static void compute_4d_tiled(const struct compute_4d_tiled_context* context,
                     tile_i, tile_j, tile_k, tile_l);
 }
 
-PTHREADPOOL_WEAK void pthreadpool_compute_4d_tiled(
+void PTHREADPOOL_IMPL(pthreadpool_compute_4d_tiled)(
     pthreadpool_t threadpool, pthreadpool_function_4d_tiled_t function,
     void* argument, size_t range_i, size_t range_j, size_t range_k,
     size_t range_l, size_t tile_i, size_t tile_j, size_t tile_k,
@@ -222,4 +221,4 @@ PTHREADPOOL_WEAK void pthreadpool_compute_4d_tiled(
   }
 }
 
-PTHREADPOOL_PRIVATE_IMPL(pthreadpool_compute_4d_tiled)
+PTHREADPOOL_WEAK_ALIAS(pthreadpool_compute_4d_tiled)