Merge branch 'awslabs-main'

Author: BwL1289

.builder/actions/aws_crt_python.py

@@ -29,12 +29,13 @@ def run(self, env):
 
         # Enable S3 tests
         env.shell.setenv('AWS_TEST_S3', '1')
+        env.shell.setenv('AWS_TEST_LOCALHOST', '1')
 
         actions = [
+            [self.python, '--version'],
             [self.python, '-m', 'pip', 'install', '--upgrade', 'pip'],
-            [self.python, '-m', 'pip', 'install', '--upgrade', '--requirement', 'requirements-dev.txt'],
             Builder.SetupCrossCICrtEnvironment(),
-            [self.python, '-m', 'pip', 'install', '--verbose', '.'],
+            [self.python, '-m', 'pip', 'install', '--verbose', '.[dev]'],
             # "--failfast" because, given how our leak-detection in tests currently works,
             # once one test fails all the rest usually fail too.
             [self.python, '-m', 'unittest', 'discover', '--verbose', '--failfast'],

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -12,6 +12,14 @@ body:
       description: What is the problem? A clear and concise description of the bug.
     validations:
       required: true
+  - type: checkboxes
+    id: regression
+    attributes:
+      label: Regression Issue
+      description: What is a regression? If it worked in a previous version but doesn't in the latest version, it's considered a regression. In this case, please provide specific version number in the report.
+      options:
+        - label: Select this option if this issue appears to be a regression.
+          required: false
   - type: textarea
     id: expected
     attributes:

.github/workflows/ci.yml

@@ -9,7 +9,7 @@ on:
 
 jobs:
   update-docs-branch:
-    runs-on: ubuntu-22.04 # latest
+    runs-on: ubuntu-22.04 # getting errors from sphinx using ubuntu-24.04, so stuck on 22.04 till we diagnose it
     permissions:
       contents: write # allow push
     steps:
@@ -20,8 +20,8 @@ jobs:
 
       - name: Update docs branch
         run: |
-          python3 -m pip install -r requirements-dev.txt
-          python3 -m pip install --verbose .
+          python3 -m pip install --upgrade pip
+          python3 -m pip install --verbose ".[dev]"
           ./scripts/make-docs.py
 
       - name: Commit

.github/workflows/docs.yml

@@ -1,7 +1,7 @@
 name: HandleStaleDiscussions
 on:
   schedule:
-    - cron: '0 */4 * * *'
+    - cron: '0 9 * * 1' # minute hour dom month dow
   discussion_comment:
     types: [created]
 

.github/workflows/handle-stale-discussions.yml

@@ -0,0 +1,32 @@
+# Apply potential regression label on issues
+name: issue-regression-label
+on:
+  issues:
+    types: [opened, edited]
+jobs:
+  add-regression-label:
+    runs-on: ubuntu-latest
+    permissions:
+      issues: write
+    steps:
+    - name: Fetch template body
+      id: check_regression
+      uses: actions/github-script@v7
+      env: 
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        TEMPLATE_BODY: ${{ github.event.issue.body }}
+      with:
+        script: |
+          const regressionPattern = /\[x\] Select this option if this issue appears to be a regression\./i;
+          const template = `${process.env.TEMPLATE_BODY}`
+          const match = regressionPattern.test(template);
+          core.setOutput('is_regression', match);
+    - name: Manage regression label
+      env:
+        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      run: |
+        if [ "${{ steps.check_regression.outputs.is_regression }}" == "true" ]; then
+          gh issue edit ${{ github.event.issue.number }} --add-label "potential-regression" -R ${{ github.repository }}
+        else
+          gh issue edit ${{ github.event.issue.number }} --remove-label "potential-regression" -R ${{ github.repository }}
+        fi

.github/workflows/issue-regression-labeler.yml

@@ -7,28 +7,19 @@ on:
       - 'docs'
 
 jobs:
-  clang-format:
-
+  lint:
     runs-on: ubuntu-24.04 # latest
 
-    steps:
-    - name: Checkout Sources
-      uses: actions/checkout@v4
-
-    - name: clang-format lint
-      run: |
-        ./format-check.py
-
-  autopep8:
-    runs-on: ubuntu-20.04 # latest
-
     steps:
     - name: Checkout Source
       uses: actions/checkout@v4
 
-    - name: Build and Test
+    - name: Format and Check Diff
+      # run formatting script, which edits files in place
+      # then do `git diff` to show what changed (if anything)
+      # then do `git diff --quiet` to fail if anything changed
       run: |
-        python3 -m pip install --upgrade setuptools
-        python3 -m pip install --upgrade wheel
         python3 -m pip install --upgrade autopep8
-        python3 -m autopep8 --exit-code --diff --recursive awscrt test .builder setup.py
+        python3 scripts/format-all.py
+        git diff
+        git diff --quiet

.github/workflows/lint.yml

@@ -3,7 +3,7 @@ name: "Close stale issues"
 # Controls when the action will run.
 on:
   schedule:
-    - cron: "*/60 * * * *"
+    - cron: '0 9 * * 1' # minute hour dom month dow
 
 jobs:
   cleanup:

.github/workflows/stale_issue.yml

@@ -386,12 +386,7 @@ poetry.toml
 pyrightconfig.json
 
 ### VisualStudioCode ###
-.vscode/*
-!.vscode/settings.json
-!.vscode/tasks.json
-!.vscode/launch.json
-!.vscode/extensions.json
-!.vscode/*.code-snippets
+.vscode
 
 # Local History for Visual Studio Code
 .history/