Skip to content

Commit aa604b2

Browse files
gilluminateeastandwestwind
authored andcommitted
speed up privacy-experiences.cy.ts (#6705)
1 parent e4936f1 commit aa604b2

File tree

20 files changed

+2039
-719
lines changed

20 files changed

+2039
-719
lines changed

.github/workflows/cypress_admin-ui.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,9 +85,10 @@ jobs:
8585
uses: actions/checkout@v4
8686

8787
- name: Use Node.js 20.x
88-
uses: actions/setup-node@v4
88+
uses: actions/setup-node@v5
8989
with:
9090
node-version: 20.x
91+
cache: "npm"
9192

9293
- name: Install dependencies
9394
run: npm ci

.github/workflows/cypress_privacy-center.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,10 @@ jobs:
2525
uses: actions/checkout@v4
2626

2727
- name: Use Node.js 20.x
28-
uses: actions/setup-node@v4
28+
uses: actions/setup-node@v5
2929
with:
3030
node-version: 20.x
31+
cache: "npm"
3132

3233
- name: Install dependencies
3334
run: npm ci

.github/workflows/frontend_checks.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,10 @@ jobs:
3131
uses: actions/checkout@v4
3232

3333
- name: Use Node.js ${{ matrix.node-version }}
34-
uses: actions/setup-node@v4
34+
uses: actions/setup-node@v5
3535
with:
3636
node-version: ${{ matrix.node-version }}
37+
cache: "npm"
3738

3839
- name: Install dependencies
3940
run: npm ci

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
7070

7171
### Developer Experience
7272
- Improved accessibility configuration for ESLint jsx-a11y plugin with Ant Design component support [#6699](https://github.com/ethyca/fides/pull/6699)
73+
- Upgraded Cypress version to latest and made additional changes to help speed up Admin UI test runs [#6705](https://github.com/ethyca/fides/pull/6705)
7374

7475
### Fixed
7576
- Fixed an issue where users were unable to cancel out of the Add New System dialog in Action Center [#6651](https://github.com/ethyca/fides/pull/6651)

clients/admin-ui/cypress/e2e/integration-management-manual-tasks.cy.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import {
22
stubIntegrationManagement,
33
stubManualTaskConfig,
44
stubPlus,
5-
stubSystemCrud,
65
} from "cypress/support/stubs";
76

87
import { INTEGRATION_MANAGEMENT_ROUTE } from "~/features/common/nav/routes";
@@ -289,7 +288,9 @@ describe("Integration Management - Manual Task Configuration", () => {
289288
cy.wait("@getUsers"); // Refresh users list
290289

291290
// Verify modal closes and user is available in dropdown
292-
cy.getByTestId("create-external-user-modal").should("not.be.visible");
291+
cy.getByTestId("create-external-user-modal").within(() => {
292+
cy.get(".ant-modal-wrap").should("not.be.visible");
293+
});
293294
});
294295

295296
it("should handle external user creation errors", () => {

0 commit comments

Comments
 (0)