Skip to content

Commit a486d7c

Browse files
committed
rename feature flag to something with a little more finesse (#6888)
1 parent a2e3a42 commit a486d7c

File tree

6 files changed

+11
-12
lines changed

6 files changed

+11
-12
lines changed

clients/admin-ui/src/features/common/nav/nav-config.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,29 +53,29 @@ export const NAV_CONFIG: NavConfigGroup[] = [
5353
title: "Action center",
5454
path: routes.ACTION_CENTER_ROUTE,
5555
scopes: [ScopeRegistryEnum.DISCOVERY_MONITOR_READ],
56-
requiresAnyFlag: ["webMonitor", "llmClassifier"],
56+
requiresAnyFlag: ["webMonitor", "heliosV2"],
5757
requiresPlus: true,
5858
},
5959
{
6060
title: "Activity",
6161
path: routes.DETECTION_DISCOVERY_ACTIVITY_ROUTE,
6262
scopes: [ScopeRegistryEnum.DISCOVERY_MONITOR_READ],
6363
requiresPlus: true,
64-
hidesIfFlag: "llmClassifier",
64+
hidesIfFlag: "heliosV2",
6565
},
6666
{
6767
title: "Data detection",
6868
path: routes.DATA_DETECTION_ROUTE,
6969
scopes: [ScopeRegistryEnum.DISCOVERY_MONITOR_READ],
7070
requiresPlus: true,
71-
hidesIfFlag: "llmClassifier",
71+
hidesIfFlag: "heliosV2",
7272
},
7373
{
7474
title: "Data discovery",
7575
path: routes.DATA_DISCOVERY_ROUTE,
7676
scopes: [ScopeRegistryEnum.DISCOVERY_MONITOR_READ],
7777
requiresPlus: true,
78-
hidesIfFlag: "llmClassifier",
78+
hidesIfFlag: "heliosV2",
7979
},
8080
{
8181
title: "Data catalog",

clients/admin-ui/src/features/data-discovery-and-detection/action-center/hooks/useTopLevelActionCenterTabs.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ export enum TopLevelActionCenterTabHash {
1010

1111
const useTopLevelActionCenterTabs = () => {
1212
const { flags } = useFeatures();
13-
const hasFullActionCenter = !!flags.llmClassifier;
13+
const hasFullActionCenter = !!flags.heliosV2;
1414

1515
const availableTabKeys = useMemo(() => {
1616
return hasFullActionCenter

clients/admin-ui/src/features/integrations/configure-monitor/ConfigureMonitorForm.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ const ConfigureMonitorForm = ({
9898
* Note: Action center can exist for web monitoring without this feature.
9999
* This flag specifically gates the LLM-based classification capabilities.
100100
*/
101-
const llmClassifierFeatureEnabled = !!flags.llmClassifier;
101+
const llmClassifierFeatureEnabled = !!flags.heliosV2;
102102

103103
const { data: appConfig } = useGetConfigurationSettingsQuery(
104104
{

clients/admin-ui/src/flags.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@
5454
"test": true,
5555
"production": false
5656
},
57-
"llmClassifier": {
57+
"heliosV2": {
5858
"description": "Support LLM classifier for Helios datastore monitor and updated Action Center view that replaces Activity, Detection, and Discovery pages",
5959
"development": true,
6060
"test": true,

clients/admin-ui/src/pages/data-discovery/action-center/datastore/[monitorId]/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const MonitorFeatureError = () => (
1414
const DatastoreMonitorResultSystems: NextPage = () => {
1515
const { flags } = useFeatures();
1616

17-
return flags.llmClassifier ? (
17+
return flags.heliosV2 ? (
1818
<ActionCenterFields />
1919
) : (
2020
<Result status="error" title={<MonitorFeatureError />} />

clients/admin-ui/src/pages/data-discovery/action-center/index.tsx

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,12 @@ const ActionCenterPage = () => {
3333
const { paginationProps, pageIndex, pageSize, resetPagination } =
3434
useAntPagination();
3535
const [searchQuery, setSearchQuery] = useState("");
36-
const { webMonitor: webMonitorEnabled, llmClassifier: llmClassifierEnabled } =
37-
flags;
36+
const { webMonitor: webMonitorEnabled, heliosV2: heliosV2Enabled } = flags;
3837

3938
// Build monitor_type filter based on enabled feature flags
4039
const monitorTypes: MONITOR_TYPES[] = [
4140
...(webMonitorEnabled ? [MONITOR_TYPES.WEBSITE] : []),
42-
...(llmClassifierEnabled ? [MONITOR_TYPES.DATASTORE] : []),
41+
...(heliosV2Enabled ? [MONITOR_TYPES.DATASTORE] : []),
4342
];
4443

4544
const { data, isError, isLoading, isFetching } =
@@ -110,7 +109,7 @@ const ActionCenterPage = () => {
110109
[],
111110
);
112111

113-
if (!webMonitorEnabled && !llmClassifierEnabled) {
112+
if (!webMonitorEnabled && !heliosV2Enabled) {
114113
return <DisabledMonitorsPage />;
115114
}
116115

0 commit comments

Comments
 (0)