Skip to content

Commit 59c6381

Browse files
committed
Fix approved status in the admin ui (#6727)
1 parent 4f2b9d0 commit 59c6381

File tree

4 files changed

+13
-8
lines changed

4 files changed

+13
-8
lines changed

clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/MonitorFieldListItem.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import ClassificationSelect from "./ClassificationSelect";
2222
import { RESOURCE_STATUS } from "./useFilters";
2323

2424
type ResourceStatusLabel = (typeof RESOURCE_STATUS)[number];
25-
type ResourceStatusLabelColor = "nectar" | "red" | "orange" | "blue";
25+
type ResourceStatusLabelColor = "nectar" | "red" | "orange" | "blue" | "green";
2626

2727
const ResourceStatus: Record<
2828
DiffStatus,
@@ -33,14 +33,15 @@ const ResourceStatus: Record<
3333
> = {
3434
classifying: { label: "Classifying", color: "blue" },
3535
classification_queued: { label: "Classifying", color: "blue" },
36-
classification_update: { label: "Classifying", color: "nectar" },
36+
classification_update: { label: "In Review", color: "nectar" },
3737
classification_addition: { label: "In Review", color: "blue" },
3838
addition: { label: "Attention Required", color: "blue" },
3939
muted: { label: "Unmonitored", color: "nectar" },
40-
removal: { label: "Attention Required", color: "red" },
40+
removal: { label: "Removed", color: "red" },
4141
removing: { label: "In Review", color: "nectar" },
4242
promoting: { label: "In Review", color: "nectar" },
43-
monitored: { label: "Approved", color: "nectar" },
43+
monitored: { label: "Confirmed", color: "nectar" },
44+
approved: { label: "Approved", color: "green" },
4445
} as const;
4546

4647
type TagRenderParams = Parameters<NonNullable<SelectProps["tagRender"]>>[0];

clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/page.tsx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ import { RESOURCE_STATUS, useMonitorFieldsFilters } from "./useFilters";
4343
const FIELD_PAGE_SIZE = 25;
4444

4545
type ResourceStatusLabel = (typeof RESOURCE_STATUS)[number];
46-
type ResourceStatusLabelColor = "nectar" | "red" | "orange" | "blue";
46+
type ResourceStatusLabelColor = "nectar" | "red" | "orange" | "blue" | "green";
4747

4848
const ResourceStatus: Record<
4949
DiffStatus,
@@ -54,14 +54,15 @@ const ResourceStatus: Record<
5454
> = {
5555
classifying: { label: "Classifying", color: "blue" },
5656
classification_queued: { label: "Classifying", color: "blue" },
57-
classification_update: { label: "Classifying", color: "nectar" },
57+
classification_update: { label: "In Review", color: "nectar" },
5858
classification_addition: { label: "In Review", color: "blue" },
5959
addition: { label: "Attention Required", color: "blue" },
6060
muted: { label: "Unmonitored", color: "nectar" },
61-
removal: { label: "Attention Required", color: "red" },
61+
removal: { label: "Removed", color: "red" },
6262
removing: { label: "In Review", color: "nectar" },
6363
promoting: { label: "In Review", color: "nectar" },
64-
monitored: { label: "Approved", color: "nectar" },
64+
monitored: { label: "Confirmed", color: "nectar" },
65+
approved: { label: "Approved", color: "green" },
6566
} as const;
6667

6768
const intoDiffStatus = (resourceStatusLabel: ResourceStatusLabel) =>

clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/useFilters.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ export const RESOURCE_STATUS = [
1414
"Classifying",
1515
"Approved",
1616
"Unmonitored",
17+
"Confirmed",
18+
"Removed",
1719
] as const;
1820

1921
export const useMonitorFieldsFilters = () => {

clients/admin-ui/src/types/api/models/DiffStatus.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,5 @@ export enum DiffStatus {
1313
PROMOTING = "promoting",
1414
REMOVAL = "removal",
1515
REMOVING = "removing",
16+
APPROVED = "approved",
1617
}

0 commit comments

Comments
 (0)