Skip to content

Commit 464d575

Browse files
committed
ENG-1911 - Review tray doesn't work well with reassigning data categories (#6931)
1 parent dd2f04e commit 464d575

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
5757
- Fixed handling of really long values in the new request manager [#6917](https://github.com/ethyca/fides/pull/6917)
5858
- Fixed Filter component bug that caused values to clear when searching through available filters [#6914](https://github.com/ethyca/fides/pull/6914)
5959
- Fixed a visual issue with the integrations detail page in smaller screens [#6925](https://github.com/ethyca/fides/pull/6925)
60+
- Fixed data type display and simplified data categories in Action Center field details [#6931](https://github.com/ethyca/fides/pull/6931)
6061

6162
## [2.73.1](https://github.com/ethyca/fides/compare/2.73.0..2.73.1)
6263

clients/admin-ui/src/features/data-discovery-and-detection/action-center/fields/ResourceDetailsDrawer.tsx

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,9 @@ export const ResourceDetailsDrawer = ({
7272
key: "data-type",
7373
label: "Data type",
7474
children:
75-
resource.resource_type /** data type is not yet returned from the BE for the details query * */,
75+
"source_data_type" in resource
76+
? resource.source_data_type
77+
: undefined,
7678
},
7779
{
7880
key: "description",
@@ -87,14 +89,11 @@ export const ResourceDetailsDrawer = ({
8789
variant="outlined"
8890
mode="multiple"
8991
maxTagCount="responsive"
90-
value={[
91-
...(resource.classifications?.map(
92-
({ label }) => label,
93-
) ?? []),
94-
...(resource.user_assigned_data_categories?.map(
95-
(value) => value,
96-
) ?? []),
97-
]}
92+
value={
93+
"preferred_data_categories" in resource
94+
? resource.preferred_data_categories
95+
: []
96+
}
9897
autoFocus={false}
9998
disabled={
10099
resource?.diff_status

clients/admin-ui/src/types/api/models/Field.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,5 @@ export type Field = {
5151
top_level_field_urn?: string | null;
5252
source_data_type?: string | null;
5353
sub_fields?: Array<Field> | null;
54+
preferred_data_categories: Array<string>;
5455
};

0 commit comments

Comments
 (0)