Fix failing cypress tests on main (#6534)

Author: eastandwestwind

src/fides/config/security_settings.py

@@ -222,10 +222,13 @@ def assemble_root_access_token(
     def validate_rate_limit_client_ip_header(
         cls,
         v: str,
-    ) -> str:
+    ) -> Optional[str]:
         """Validate supported `rate_limit_client_ip_header`"""
         insecure_headers = ["x-forwarded-for"]
 
+        if not v:
+            return None
+
         if v.lower() in insecure_headers:
             raise ValueError(
                 "The rate_limit_client_ip_header cannot be set to a header that is not secure."

tests/ops/api/test_ratelimit.py

@@ -1,55 +1,6 @@
-from typing import Generator
-
 import pytest
-from fastapi.testclient import TestClient
-from slowapi.extension import Limiter
-from slowapi.util import get_remote_address
-
-from fides.api.main import app
-from fides.common.api.v1.urn_registry import HEALTH
-from fides.config import CONFIG, SecuritySettings
-
-LIMIT = 2
-
-
-@pytest.fixture(scope="function")
-def api_client_for_rate_limiting() -> Generator:
-    """
-    Return a client used to make API requests ratelimited at 2/minute.
-    """
-    app.state.limiter = Limiter(
-        default_limits=[f"{LIMIT}/minute"],
-        headers_enabled=True,
-        key_prefix=CONFIG.security.rate_limit_prefix,
-        key_func=get_remote_address,
-        retry_after="http-date",
-    )
-    with TestClient(app) as c:
-        yield c
-        app.state.limiter = Limiter(
-            default_limits=[CONFIG.security.request_rate_limit],
-            headers_enabled=True,
-            key_prefix=CONFIG.security.rate_limit_prefix,
-            key_func=get_remote_address,
-            retry_after="http-date",
-        )
-
-
-def test_requests_rate_limited(api_client_for_rate_limiting):
-    """
-    Asserts that incremental HTTP requests above the ratelimit threshold are
-    rebuffed from the API with a 429 response.
-
-    A theoretical failure condition exists in this test should the container
-    running it not be able to execute 100 requests against the client in a
-    one minute period.
-    """
-    for _ in range(0, LIMIT):
-        response = api_client_for_rate_limiting.get(HEALTH)
-        assert response.status_code == 200
 
-    response = api_client_for_rate_limiting.get(HEALTH)
-    assert response.status_code == 429
+from fides.config import SecuritySettings
 
 
 def test_rate_limit_validation():