feat: op-signer: Connect to sequencers [9/N] (#389)

janjakubnanista · web-flow · commit bc4580847109 · 2025-08-26T10:56:08.000-07:00
**Description**

Addresses an additional request to be able to use `op-signer` with
`kona-node`.

This meant that the signer needs to be launched not in `launcher__hack`
but in `launcher` so it was moved there and passed to `launcher__hack`
in the return value (`original_launcher_output__hack.signer`).
diff --git a/.github/tests/kona-node-signer.yaml b/.github/tests/kona-node-signer.yaml
@@ -0,0 +1,53 @@
+optimism_package:
+  chains:
+    opkurtosis:
+      participants:
+        node0:
+          sequencer: true
+          el:
+            type: op-geth
+          cl:
+            type: op-node
+            log_level: debug
+        node1:
+          sequencer: false
+          el:
+            type: op-geth
+          cl:
+            type: kona-node
+            log_level: debug
+      signer_params:
+        enabled: true
+      network_params:
+        network: "konatosis"
+        network_id: "2151909"
+        seconds_per_slot: 2
+        fjord_time_offset: 0
+        granite_time_offset: 0
+        fund_dev_accounts: true
+  op_contract_deployer_params:
+    image: us-docker.pkg.dev/oplabs-tools-artifacts/images/op-deployer:v0.4.0-rc.2
+    l1_artifacts_locator: https://storage.googleapis.com/oplabs-contract-artifacts/artifacts-v1-02024c5a26c16fc1a5c716fff1c46b5bf7f23890d431bb554ddbad60971211d4.tar.gz
+    l2_artifacts_locator: https://storage.googleapis.com/oplabs-contract-artifacts/artifacts-v1-02024c5a26c16fc1a5c716fff1c46b5bf7f23890d431bb554ddbad60971211d4.tar.gz
+  global_log_level: "info"
+  global_node_selectors: {}
+  global_tolerations: []
+  persistent: false
+ethereum_package:
+  participants:
+  - el_type: geth
+    cl_type: lighthouse
+    cl_image: "ethpandaops/lighthouse:stable-e21198c"
+  network_params:
+    preset: minimal
+    genesis_delay: 5
+    additional_preloaded_contracts: '
+      {
+        "0x4e59b44847b379578588920cA78FbF26c0B4956C": {
+          "balance": "0ETH",
+          "code": "0x7fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffe03601600081602082378035828234f58015156039578182fd5b8082525050506014600cf3",
+          "storage": {},
+          "nonce": "1"
+        }
+      }
+    '
diff --git a/.github/workflows/per-pr.yml b/.github/workflows/per-pr.yml
@@ -15,6 +15,7 @@ jobs:
         file_name:
           [
             "./network_params.yaml",
+            "./.github/tests/kona-node-signer.yaml"
           ]
     runs-on: ubuntu-latest
     steps:
diff --git a/main.star b/main.star
@@ -150,6 +150,7 @@ def run(plan, args={}):
                 log_level=global_log_level,
                 tolerations=global_tolerations,
                 persistent=persistent,
+                registry=registry,
             )
         )
 
diff --git a/src/cl/kona-node/launcher.star b/src/cl/kona-node/launcher.star
@@ -54,6 +54,7 @@ def launch(
     node_selectors,
     el_context,
     cl_contexts,
+    signer_context,
     l1_config_env_vars,
     observability_helper,
 ):
@@ -97,6 +98,7 @@ def launch(
         node_selectors=cl_node_selectors,
         el_context=el_context,
         cl_contexts=cl_contexts,
+        signer_context=signer_context,
         l1_config_env_vars=l1_config_env_vars,
         observability_helper=observability_helper,
     )
@@ -147,6 +149,7 @@ def get_service_config(
     node_selectors,
     el_context,
     cl_contexts,
+    signer_context,
     l1_config_env_vars,
     observability_helper,
 ):
@@ -226,19 +229,51 @@ def get_service_config(
     # apply customizations
 
     if is_sequencer:
-        sequencer_private_key = _util.read_network_config_value(
-            plan,
-            deployment_output,
-            "sequencer-{0}".format(network_params.network_id),
-            ".privateKey",
-        )
-
         cmd += [
             "--mode=sequencer",
-            "--p2p.sequencer.key=" + sequencer_private_key,
             "--sequencer.l1-confs=2",
         ]
 
+        # kona-node sequencer flags for remote and local signer are exclusive
+        # so we have to treat them accordingly and only supply the ones that apply to our case
+        if signer_context:
+            # In case of remote signer, we need to supply the certificates & endpoint
+            sequencer_address = _util.read_network_config_value(
+                plan,
+                deployment_output,
+                "sequencer-{}".format(network_params.network_id),
+                ".address",
+            )
+
+            cmd += [
+                "--p2p.signer.tls.ca={}".format(signer_context.credentials.ca.crt),
+                "--p2p.signer.tls.cert={}".format(
+                    signer_context.credentials.hosts[params.service_name].tls.crt
+                ),
+                "--p2p.signer.tls.key={}".format(
+                    signer_context.credentials.hosts[params.service_name].tls.key
+                ),
+                "--p2p.signer.endpoint={}".format(
+                    _net.service_url(
+                        signer_context.service.hostname,
+                        signer_context.service.ports[_net.HTTP_PORT_NAME],
+                    )
+                ),
+                "--p2p.signer.address={}".format(sequencer_address),
+            ]
+        else:
+            # In case of local signer, we need to supply the private key
+            sequencer_private_key = _util.read_network_config_value(
+                plan,
+                deployment_output,
+                "sequencer-{0}".format(network_params.network_id),
+                ".privateKey",
+            )
+
+            cmd += [
+                "--p2p.sequencer.key=" + sequencer_private_key,
+            ]
+
     if conductor_params:
         cmd += [
             "--conductor.rpc={0}".format(
diff --git a/src/cl/launcher.star b/src/cl/launcher.star
@@ -18,6 +18,7 @@ def launch(
     deployment_output,
     el_context,
     cl_contexts,
+    signer_context,
     l1_config_env_vars,
     log_level,
     persistent,
@@ -62,6 +63,7 @@ def launch(
             deployment_output=deployment_output,
             el_context=el_context,
             cl_contexts=cl_contexts,
+            signer_context=signer_context,
             l1_config_env_vars=l1_config_env_vars,
             log_level=log_level,
             persistent=persistent,
diff --git a/src/l2/launcher.star b/src/l2/launcher.star
@@ -1,6 +1,7 @@
 _cl_launcher = import_module("/src/cl/launcher.star")
 _el_launcher = import_module("/src/el/launcher.star")
 _da_server_launcher = import_module("/src/da/da-server/launcher.star")
+_op_signer_launcher = import_module("/src/signer/op-signer/launcher.star")
 _rollup_boost_launcher = import_module("/src/mev/rollup-boost/launcher.star")
 
 _selectors = import_module("./selectors.star")
@@ -21,6 +22,7 @@ def launch(
     tolerations,
     node_selectors,
     observability_helper,
+    registry,
 ):
     network_params = params.network_params
     network_name = network_params.name
@@ -36,6 +38,54 @@ def launch(
         plan=plan, da_params=params.da_params, log_prefix=network_log_prefix
     )
 
+    # We'll need batcher private key for the batcher as well as for the signer
+    batcher_private_key = _util.read_network_config_value(
+        plan,
+        deployment_output,
+        "batcher-{0}".format(network_params.network_id),
+        ".privateKey",
+    )
+
+    # We'll need proposer private key for the proposer as well as for the signer
+    proposer_private_key = _util.read_network_config_value(
+        plan,
+        deployment_output,
+        "proposer-{0}".format(network_params.network_id),
+        ".privateKey",
+    )
+
+    sequencer_private_key = _util.read_network_config_value(
+        plan,
+        deployment_output,
+        "sequencer-{0}".format(network_params.network_id),
+        ".privateKey",
+    )
+
+    signer = _launch_signer_maybe(
+        plan=plan,
+        signer_params=params.signer_params,
+        network_params=network_params,
+        clients=[
+            struct(
+                hostname=params.batcher_params.service_name,
+                private_key=batcher_private_key,
+            ),
+            struct(
+                hostname=params.proposer_params.service_name,
+                private_key=proposer_private_key,
+            ),
+        ]
+        + [
+            struct(
+                hostname=participant_params.cl.service_name,
+                private_key=sequencer_private_key,
+            )
+            for participant_params in params.participants
+        ],
+        registry=registry,
+        log_prefix=network_log_prefix,
+    )
+
     #
     # Launch CL & EL clients
     #
@@ -112,6 +162,7 @@ def launch(
             da_params=params.da_params,
             el_context=el.context,
             cl_contexts=cl_contexts,
+            signer_context=signer,
             jwt_file=jwt_file,
             deployment_output=deployment_output,
             l1_config_env_vars=l1_config_env_vars,
@@ -146,6 +197,7 @@ def launch(
             if sidecar_and_builders and sidecar_and_builders.el_builder
             else el.context,
             cl_contexts=cl_contexts,
+            signer_context=signer,
             jwt_file=jwt_file,
             deployment_output=deployment_output,
             l1_config_env_vars=l1_config_env_vars,
@@ -171,6 +223,7 @@ def launch(
         network_id=network_params.network_id,
         participants=participants,
         da=da,
+        signer=signer,
     )
 
 
@@ -197,6 +250,7 @@ def _launch_sidecar_maybe(
     is_sequencer,
     el_context,
     cl_contexts,
+    signer_context,
     jwt_file,
     deployment_output,
     l1_config_env_vars,
@@ -291,6 +345,7 @@ def _launch_sidecar_maybe(
             is_sequencer=True,
             el_context=el_builder_context,
             cl_contexts=cl_contexts,
+            signer_context=signer_context,
             jwt_file=jwt_file,
             deployment_output=deployment_output,
             l1_config_env_vars=l1_config_env_vars,
@@ -323,3 +378,20 @@ def _launch_sidecar(
         )
     else:
         fail("Invalid MEV type: {}".format(mev_params.type))
+
+
+def _launch_signer_maybe(
+    plan, signer_params, network_params, clients, registry, log_prefix
+):
+    if signer_params:
+        plan.print("{}: Launching signer".format(log_prefix))
+
+        _op_signer_launcher.launch(
+            plan=plan,
+            params=signer_params,
+            network_params=network_params,
+            clients=clients,
+            registry=registry,
+        )
+
+        plan.print("{}: Successfully launched signer".format(log_prefix))
diff --git a/src/l2/launcher__hack.star b/src/l2/launcher__hack.star
@@ -3,7 +3,6 @@ _op_batcher_launcher = import_module("/src/batcher/op-batcher/launcher.star")
 _op_conductor_launcher = import_module("/src/conductor/op-conductor/launcher.star")
 _op_proposer_launcher = import_module("/src/proposer/op-proposer/launcher.star")
 _proxyd_launcher = import_module("/src/proxyd/launcher.star")
-_op_signer_launcher = import_module("/src/signer/op-signer/launcher.star")
 _tx_fuzzer_launcher = import_module("/src/tx-fuzzer/launcher.star")
 _op_conductor_ops_launcher = import_module(
     "/src/conductor/op-conductor-ops/launcher.star"
@@ -94,24 +93,6 @@ def launch(
         ".privateKey",
     )
 
-    signer_context = _launch_signer_maybe(
-        plan=plan,
-        signer_params=params.signer_params,
-        network_params=network_params,
-        clients=[
-            struct(
-                hostname=params.batcher_params.service_name,
-                private_key=batcher_private_key,
-            ),
-            struct(
-                hostname=params.proposer_params.service_name,
-                private_key=proposer_private_key,
-            ),
-        ],
-        registry=registry,
-        log_prefix=network_log_prefix,
-    )
-
     _launch_batcher(
         plan=plan,
         batcher_params=params.batcher_params,
@@ -123,7 +104,7 @@ def launch(
         da_server_context=original_launcher_output__hack.da.context
         if original_launcher_output__hack.da
         else None,
-        signer_context=signer_context,
+        signer_context=original_launcher_output__hack.signer,
         observability_helper=observability_helper,
         log_prefix=network_log_prefix,
     )
@@ -137,7 +118,7 @@ def launch(
         private_key=proposer_private_key,
         l1_config_env_vars=l1_config_env_vars,
         observability_helper=observability_helper,
-        signer_context=signer_context,
+        signer_context=original_launcher_output__hack.signer,
         log_prefix=network_log_prefix,
     )
 
@@ -253,23 +234,6 @@ def _launch_proxyd_maybe(
         plan.print("{}: Successfully launched proxyd".format(log_prefix))
 
 
-def _launch_signer_maybe(
-    plan, signer_params, network_params, clients, registry, log_prefix
-):
-    if signer_params:
-        plan.print("{}: Launching signer".format(log_prefix))
-
-        _op_signer_launcher.launch(
-            plan=plan,
-            params=signer_params,
-            network_params=network_params,
-            clients=clients,
-            registry=registry,
-        )
-
-        plan.print("{}: Successfully launched signer".format(log_prefix))
-
-
 def _launch_batcher(
     plan,
     batcher_params,
diff --git a/test/cl/launcher_test.star b/test/cl/launcher_test.star

Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ jobs:`
`15`	`15`	`file_name:`
`16`	`16`	`[`
`17`	`17`	`"./network_params.yaml",`
	`18`	`+ "./.github/tests/kona-node-signer.yaml"`
`18`	`19`	`]`
`19`	`20`	`runs-on: ubuntu-latest`
`20`	`21`	`steps:`
Original file line number	Diff line number	Diff line change
`@@ -150,6 +150,7 @@ def run(plan, args={}):`
`150`	`150`	`log_level=global_log_level,`
`151`	`151`	`tolerations=global_tolerations,`
`152`	`152`	`persistent=persistent,`
	`153`	`+ registry=registry,`
`153`	`154`	`)`
`154`	`155`	`)`
`155`	`156`