feat: add curve params and negative tests

Author: LouisTsai-Csie

tests/osaka/eip7951_p256verify_precompiles/spec.py

@@ -93,6 +93,12 @@ class Spec:
     # Gas constants
     P256VERIFY_GAS = 3450
 
+    # Curve Parameters
+    P = 0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFF  ## Base field modulus
+    A = 0xFFFFFFFF00000001000000000000000000000000FFFFFFFFFFFFFFFFFFFFFFFC  ## Curve Coefficient
+    B = 0x5AC635D8AA3A93E7B3EBBD55769886BC651D06B0CC53B0F63BCE3C3E27D2604B  ## Curve Coefficient
+    N = 0xFFFFFFFF00000000FFFFFFFFFFFFFFFFBCE6FAADA7179E84F3B9CAC2FC632551  ## Subgroup Order
+
     # Other constants
     SUCCESS_RETURN_VALUE = b"\x01".rjust(32, b"\x00")
     INVALID_RETURN_VALUE = b""

tests/osaka/eip7951_p256verify_precompiles/test_p256verify_precompile_module.py

@@ -14,7 +14,7 @@
 from ethereum_test_tools import Opcodes as Op
 
 from .helpers import vectors_from_file
-from .spec import Spec, ref_spec_7951
+from .spec import H, R, S, Spec, X, Y, ref_spec_7951
 
 REFERENCE_SPEC_GIT_PATH = ref_spec_7951.git_path
 REFERENCE_SPEC_VERSION = ref_spec_7951.version
@@ -30,11 +30,80 @@
 )
 @pytest.mark.parametrize("precompile_address", [Spec.P256VERIFY], ids=[""])
 @pytest.mark.eip_checklist("new_precompile/test/call_contexts/normal")
+@pytest.mark.eip_checklist("new_precompile/test/inputs/valid")
 def test_valid(state_test: StateTestFiller, pre: Alloc, post: dict, tx: Transaction):
     """Test P256Verify precompile."""
     state_test(env=Environment(), pre=pre, post=post, tx=tx)
 
 
+@pytest.mark.parametrize(
+    "input_data",
+    [
+        pytest.param(b"", id="zero_length_input"),
+        pytest.param(
+            b"\x00" + Spec.H0 + Spec.R0 + Spec.S0 + Spec.X0 + Spec.Y0,
+            id="input_too_long",
+        ),
+        pytest.param(
+            (Spec.H0 + Spec.R0 + Spec.S0 + Spec.X0 + Spec.Y0)[:-1],
+            id="input_too_short",
+        ),
+        pytest.param(
+            H(0) + R(0) + S(0) + X(0) + Y(0),
+            id="input_all_zeros",
+        ),
+        pytest.param(
+            Spec.H0 + R(0) + Spec.S0 + Spec.X0 + Spec.Y0,
+            id="r_eq_to_zero",
+        ),
+        pytest.param(
+            Spec.H0 + R(Spec.N) + Spec.S0 + Spec.X0 + Spec.Y0,
+            id="r_eq_to_n",
+        ),
+        pytest.param(
+            Spec.H0 + Spec.R0 + S(0) + Spec.X0 + Spec.Y0,
+            id="s_eq_to_zero",
+        ),
+        pytest.param(
+            Spec.H0 + Spec.R0 + S(Spec.N) + Spec.X0 + Spec.Y0,
+            id="s_eq_to_n",
+        ),
+        pytest.param(
+            Spec.H0 + Spec.R0 + Spec.S0 + X(Spec.P) + Spec.Y0,
+            id="x_eq_to_p",
+        ),
+        pytest.param(
+            Spec.H0 + Spec.R0 + Spec.S0 + Spec.X0 + Y(Spec.P),
+            id="y_eq_to_p",
+        ),
+        pytest.param(
+            Spec.H0 + Spec.R0 + Spec.S0 + X(0) + Y(0),
+            id="point_on_infinity",
+        ),
+        pytest.param(
+            Spec.H0 + Spec.R0 + Spec.S0 + (Spec.X0 + 1) + Spec.Y0,
+            id="point_not_on_curve_x",
+        ),
+        pytest.param(
+            Spec.H0 + Spec.R0 + Spec.S0 + Spec.X0 + (Spec.Y0 + 1),
+            id="point_not_on_curve_y",
+        ),
+    ],
+)
+@pytest.mark.parametrize("expected_output", [Spec.INVALID_RETURN_VALUE], ids=[""])
+@pytest.mark.parametrize("precompile_address", [Spec.P256VERIFY], ids=[""])
+@pytest.mark.eip_checklist("new_precompile/test/inputs/all_zeros")
+@pytest.mark.eip_checklist("new_precompile/test/inputs/invalid")
+@pytest.mark.eip_checklist("new_precompile/test/inputs/invalid/crypto")
+@pytest.mark.eip_checklist("new_precompile/test/inputs/invalid/corrupted")
+@pytest.mark.eip_checklist("new_precompile/test/input_lengths/static/correct")
+@pytest.mark.eip_checklist("new_precompile/test/input_lengths/static/too_short")
+@pytest.mark.eip_checklist("new_precompile/test/input_lengths/static/too_long")
+def test_invalid(state_test: StateTestFiller, pre: Alloc, post: dict, tx: Transaction):
+    """Negative tests for the P256VERIFY precompile."""
+    state_test(env=Environment(), pre=pre, post=post, tx=tx)
+
+
 @pytest.mark.parametrize(
     "input_data,expected_output,precompile_gas_modifier,call_succeeds",
     [