Open
Description
As discussed in #2465 (comment)
NOTE: On closer inspection, it's already possible to advertise service UUIDs with NRF.setAdvertising({ 0x180D : undefined });
- so adding services
isn't needed!
Right now we add services (inc Nordic UART which was too big for the main advertisement and is added by default) to the scan response, which uses more power and is also less reliable for discovery.
Also if you add additional services with the slightly odd api:
NRF.setServices(undefined, {
advertise: [ '180D' ] // optional, list of service UUIDs to advertise
});
So:
- Bluetooth LE: Advertise Pur3 Manufacturer ID (0x0590) in Advertising packet by default #2628 added the Espruino 0x0590 UUID to advertisments, so that can be used for filtering when pairing, and we can remove the Nordic UART service by default in future builds
-
NRF.setAdvertising({}, {services : [...] });
(and for getAdvertisingData) should be added to allow services to be added to advertisements easily -
NRF.setScanResponse
can be modified so the call style is the same as setAdvertising (eg avoidNRF.setScanResponse(NRF.getAdvertisingData(...))
) - What do we do about services like HID that we advertise automatically??
Do we keep doing that unlessMaybe just keep HID in for now - you can always work around it by usingNRF.setAdvertising({}, {services : [...] });
is specified when we just advertise what was requested and nothing more?getAdvertisingData
manually - NRF.setServices...advertise should be deprecated
Metadata
Metadata
Assignees
Labels
No labels