fix(esp_linenoise): close eventfd associated with an instance when de… #611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SoucheSouche
force-pushed
the
fix/esp_linenoise_eventfd_closing
branch
from
f74663e to
627129c
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
SoucheSouche
force-pushed
the
fix/esp_linenoise_eventfd_closing
branch
2 times, most recently
from
b8e17af to
4da6a75
Compare
Collaborator
|
LGTM! You may want to state in the KConfig that the bigger the |
SoucheSouche
force-pushed
the
fix/esp_linenoise_eventfd_closing
branch
from
4da6a75 to
e869314
Compare
…leting it Add a Kconfig option to let the user select the maximum number of instance that are possible to be created simultaneously. Update the behavioral tests to test this new feature.
SoucheSouche
force-pushed
the
fix/esp_linenoise_eventfd_closing
branch
from
e869314 to
bc12f55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change description
When deleting a linenoise instance, the linked list of in_fd / evenfd pair item is removed from the list but the evenfd is not closed.
When creating and deleting a lot of esp_linenoise instances, this causes the eventfd to eventually reach the MAX number of FD it can create.
Closing the eventfd associated with the esp_linenoise instance when deleting the instance prevents this.