fix(usb_host_hid): Fixed a vulnerability with overwrite freed heap memory #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…fer on large report descriptors - Made all the null checks before any dereference - Fixed the unlock path on usb_host_transfer_alloc() error - Clamped req->wLength to some sane maximum (2048 bytes)
roma-jam
force-pushed
the
fix/report_descriptor_pointer_usage_on_realloc
branch
from
5913c4c to
54c89ff
Compare
tore-espressif
approved these changes
Nov 14, 2025
Collaborator
tore-espressif
left a comment
tore-espressif
left a comment
There was a problem hiding this comment.
LGTM.
Please consider adding tests for this situation
| if (ctrl_xfer->actual_num_bytes < USB_SETUP_PACKET_SIZE) { | ||
| ret = ESP_ERR_INVALID_SIZE; | ||
| } else { | ||
| ctrl_xfer->actual_num_bytes -= USB_SETUP_PACKET_SIZE; |
Collaborator
There was a problem hiding this comment.
Nitpick: actual_num_bytes should be modified by the Host driver only.
I suggest adding intermediate variable for clarity
const size_t hid_report_len = ctrl_xfer->actual_num_bytes - USB_SETUP_PACKET_SIZE;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Main change
ctrl_xferlocal pointer usageAdditional clean-up
usb_host_transfer_alloc()errorreq->wLengthto some sane maximum: 2048 bytesRelated
Testing
Checklist
Before submitting a Pull Request, please ensure the following: