fix(uvc): Fixed potential buffer overflow in desc printing #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
roma-jam
approved these changes
Nov 13, 2025
igi540
approved these changes
Nov 13, 2025
Collaborator
There was a problem hiding this comment.
LGTM. Just one question: Can you confirm that reading the UVC frame descriptor via a direct struct cast is safe across all supported targets (S2/S3/H4/P4) and memory regions (SRAM/PSRAM)?
C makes unaligned struct reads UB, and behavior may vary by arch/toolchain..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed memcpy from this originally 3rd party code.
ESP targets support unaligned access.