Skip to content

Conversation

@roma-jam
Copy link
Collaborator

@roma-jam roma-jam commented Nov 11, 2025

Description

Goal: Decreases the Build CI time for Device test apps from 25m 20s to 19m 52s (~5m faster)

This is a first part of the cleaning up the CI.
This PR removes the test apps that aren't run.

In the second PR, I will merge the rest applications, that I added recently (with v2.0.0 we are able to configure the device stack in runtime, so now we can have one application).

After this PR, only applications that are running in CI will be left:

The part 2 I will prepare after merging the VBUS monitor feature.

Important

usb_cv test application also removed (and from excluded paths) as we do not build it. So there is no point to keep the code in the repo and neither build it, neither run it.

Related

Testing

  • N/A

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@roma-jam roma-jam added this to the esp_tinyusb v2.0.2 milestone Nov 11, 2025
@roma-jam roma-jam self-assigned this Nov 11, 2025
@roma-jam roma-jam force-pushed the cleanup/esp_tinyusb_test_apps branch from 9305954 to 0753be7 Compare November 11, 2025 11:43
@roma-jam roma-jam requested a review from Copilot November 11, 2025 11:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused test applications from the esp_tinyusb device stack to reduce CI build time by approximately 5 minutes (from 25m 20s to 19m 52s). The removed applications (usb_cv and ncm) are not executed in CI, making them unnecessary overhead in the build process.

  • Removes usb_cv test application and its exclusion from build configuration
  • Removes ncm test application
  • Maintains only CI-executed test apps: dconn_detection, msc_storage, runtime_config, and teardown_device

Reviewed Changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.

File Description
.idf_build_apps.toml Removed usb_cv from excluded paths since the entire application is being deleted
device/esp_tinyusb/test_apps/usb_cv/* Removed entire usb_cv test application directory including source files, configurations, and build files
device/esp_tinyusb/test_apps/ncm/* Removed entire ncm test application directory including source files, configurations, and build files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@roma-jam roma-jam marked this pull request as ready for review November 11, 2025 11:56
@roma-jam roma-jam added the CI CI related PR label Nov 11, 2025
@roma-jam roma-jam marked this pull request as draft November 11, 2025 20:20
@roma-jam roma-jam changed the title cleanup(esp_tinyusb): Removed test apps, that are not run in CI (part1/2) cleanup(esp_tinyusb): Removed test apps, that are not run in CI (part1/2) [WIP] Nov 11, 2025
@roma-jam roma-jam changed the title cleanup(esp_tinyusb): Removed test apps, that are not run in CI (part1/2) [WIP] cleanup(esp_tinyusb): Removed test apps, that are not run in CI [WIP] Nov 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI related PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants