Draft: UVC bandwidth #312
Draft
Draft: UVC bandwidth #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor UVC stream opening operations to following order: 1. Find and open underlaying USB device (and cache CFG descriptor) 2. Find interface number for requested format: bInterfaceNumber is needed for Control transfers during format negotiation 3. Negotiate the format: negotiated result is needed for correct size of frame buffers and for selecting of bandwidth in ISOC cameras 4. Allocate the frame buffers 5. Find the interface endpoint that fits our requirements and claim it: the endpoint descriptor is needed for proper USB transfer allocation 6. Allocate the USB transfer
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ESP_GOTO_ON_ERROR( | ||
| uvc_transfers_allocate(uvc_stream, stream_config->advanced.number_of_urbs, stream_config->advanced.urb_size, ep_desc), | ||
| err, TAG,); | ||
| ESP_RETURN_ON_ERROR( |
Check warning
Code scanning / clang-tidy
Potential leak of memory pointed to by 'uvc_stream' [clang-analyzer-unix.Malloc] Warning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #279