-
Notifications
You must be signed in to change notification settings - Fork 35
fix(uvc): improve uac compatibility and add checks for uvc #308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TDA-2030
wants to merge
4
commits into
master
Choose a base branch
from
fix/improve_uac_compatibility_and_add_checks_for_uvc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
bffcba8
fix(uvc): add mjpeg and uvc payload header checks
TDA-2030 6621975
fix(uac): improve uac compatibility for full-speed device
TDA-2030 0d8f1fe
fix(uvc): add camera format print in basic_uvc_stream
TDA-2030 fd1c730
fix(uac): add audio_player example
TDA-2030 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 changes: 6 additions & 0 deletions
6
host/class/uac/usb_host_uac/examples/audio_player/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| # The following lines of boilerplate have to be in your project's CMakeLists | ||
| # in this exact order for cmake to work correctly | ||
| cmake_minimum_required(VERSION 3.5) | ||
|
|
||
| include($ENV{IDF_PATH}/tools/cmake/project.cmake) | ||
| project(audio_player) |
12 changes: 12 additions & 0 deletions
12
host/class/uac/usb_host_uac/examples/audio_player/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| | Supported Targets | ESP32-S2 | ESP32-S3 | ESP32-P4 | | ||
| | ----------------- | -------- | -------- | -------- | | ||
|
|
||
| # UVC driver example: Video stream | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Outdated description. It would be nice to provide a simple 'how-to' use this example |
||
|
|
||
| ## Selecting the USB Component | ||
|
|
||
| To manually select which USB Component shall be used to build this example, please refer to the following documentation page: [Manual USB component selection](../../../../../../docs/host/usb_host_lib/usb_component_manual_selection.md). | ||
|
|
||
| ## Enable MIC playback | ||
|
|
||
| To enable MIC playback in menuconfig `(Top) → Example USB Audio Player → Playback audio from microphone` | ||
3 changes: 3 additions & 0 deletions
3
host/class/uac/usb_host_uac/examples/audio_player/main/CMakeLists.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| idf_component_register(SRC_DIRS . | ||
| INCLUDE_DIRS "." | ||
| EMBED_FILES ../spiffs/output_8k.wav ../spiffs/output_16k.wav) |
8 changes: 8 additions & 0 deletions
8
host/class/uac/usb_host_uac/examples/audio_player/main/Kconfig.projbuild
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| menu "Example USB Audio Player" | ||
| config EXAMPLE_MIC_PLAYBACK | ||
| bool "Playback audio from microphone" | ||
| default n | ||
| help | ||
| Enabled this to playback audio from microphone | ||
|
|
||
| endmenu |
10 changes: 10 additions & 0 deletions
10
host/class/uac/usb_host_uac/examples/audio_player/main/idf_component.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| dependencies: | ||
| idf: ">=5.0" # The version of the ESP-IDF that esp-audio-player requires | ||
| usb_host_uac: | ||
| override_path: ../../../../usb_host_uac/ | ||
| espressif/usb: | ||
| version: "*" | ||
| override_path: "../../../../../../usb" | ||
| rules: # Both if clauses must be fulfilled to override the component | ||
| - if: "$ENV_VAR_USB_COMP_MANAGED == yes" # Environmental variable to select between managed (esp-usb) and native (esp-idf) USB Component | ||
| - if: "idf_version >=5.4" # Use managed component only for 5.4 and above |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should work also on H4