Bugfix/fix master multiple errors handling #137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issues when the response time of master is set incorrectly and the slave response is received right after slave response time to master. This causes the transaction dropped due to expiration and the error is generated which error will be handled right after start of next transaction with following incorrect handling. Multiple errors can be generated in some other incorrect workflow. In some following sequence it may cause even incorrect allocation of buffer and crash.
Related
#135
Testing
Tested using simulator and scripts manually with different conditions including incorrect settings of slave response time and different slave response silent time. After apply of fix the reproduced issue does not happen with any of the test scenarios that were triggering errors or even crash.
In some cases, a race condition can still occur if the communication objects configured incorrectly, but it is less common.
Checklist
Before submitting a Pull Request, please ensure the following: