Skip to content

Conversation

@alisitsyn
Copy link
Collaborator

@alisitsyn alisitsyn commented Sep 18, 2025

Description

This PR addresses the issues when the response time of master is set incorrectly and the slave response is received right after slave response time to master. This causes the transaction dropped due to expiration and the error is generated which error will be handled right after start of next transaction with following incorrect handling. Multiple errors can be generated in some other incorrect workflow. In some following sequence it may cause even incorrect allocation of buffer and crash.

Related

#135

Testing

Tested using simulator and scripts manually with different conditions including incorrect settings of slave response time and different slave response silent time. After apply of fix the reproduced issue does not happen with any of the test scenarios that were triggering errors or even crash.

In some cases, a race condition can still occur if the communication objects configured incorrectly, but it is less common.


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • [-] Documentation is updated as needed.
  • [-] Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@alisitsyn alisitsyn force-pushed the bugfix/fix_master_multiple_errors_handling branch from de19b81 to 3371343 Compare September 25, 2025 09:12
@alisitsyn alisitsyn self-assigned this Sep 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants