Dependency on esp_wifi_remote / esp_hosted adds a few hundred k to image size for ESP32-P4 (AUD-6621)

[ftab]

Environment

• Audio development kit: custom board
• [Required] Module or chip used: ESP32-P4
• [Required] IDF version (run git describe --tags in $IDF_PATH folder to find it): v5.5
• [Required] ADF version (run git describe --tags in $ADF_PATH folder to find it): v2.7-135-g10dc80cd
• Build system: idf.py
• [Required] Running log: n/a
• Compiler version (run xtensa-esp32-elf-gcc --version in your project folder to find it): riscv32-esp-elf-gcc (crosstool-NG esp-14.2.0_20241119) 14.2.0
• Operating system: all
• Using an IDE?: no
• Power supply: On board

Problem Description

Without adding esp_hosted and esp_wifi_remote as dependencies to the project, it fails to build:

In file included from /Users/mac/esp/esp-adf/components/esp_peripherals/periph_wifi.c:30:
/Users/mac/esp/esp-adf/components/esp_peripherals/periph_wifi.c: In function '_wifi_init':
/Users/mac/esp/esp-adf/esp-idf/components/esp_wifi/include/esp_wifi.h:311:26: error: 'CONFIG_ESP_WIFI_STATIC_RX_BUFFER_NUM' undeclared (first use in this function); did you mean 'CONFIG_ETH_DMA_RX_BUFFER_NUM'?
  311 |     .static_rx_buf_num = CONFIG_ESP_WIFI_STATIC_RX_BUFFER_NUM,\
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Everything depends on esp_peripherals. I've tried to weasel my way out of including any network connectivity in this project because it doesn't need it. But periph_wifi.c persists.

Expected Behavior

There should be no dependency on wifi in projects that do not need it

Actual Behavior

I need to add esp_hosted and esp_wifi_remote to my project, and it adds extra size to my binary

Steps to Reproduce

Build a project that doesn't need WiFi, like pipeline_sd_card_mp3_control

Add esp_hosted and esp_wifi_remote as dependencies to get it to build

See idf.py size-components: libespressif__esp_hosted.a, etc.

[TempoTian]

You can apply following patch to fixed it, remove the idf_component.yml in main folder also, we will commit it soon.

diff --git a/components/esp_peripherals/CMakeLists.txt b/components/esp_peripherals/CMakeLists.txt
index 40d9610ce..7ff2c43f2 100644
--- a/components/esp_peripherals/CMakeLists.txt
+++ b/components/esp_peripherals/CMakeLists.txt
@@ -18,7 +18,6 @@ list(APPEND COMPONENT_SRCS ./esp_peripherals.c
                 ./periph_is31fl3216.c
                 ./periph_led.c
                 ./periph_spiffs.c
-                ./periph_wifi.c
                 ./periph_aw2013.c
                 ./periph_ws2812.c
                 ./periph_lcd.c
@@ -30,7 +29,11 @@ list(APPEND COMPONENT_SRCS ./esp_peripherals.c
                 ./lib/tca9554/tca9554.c
                 ./lib/gpio_isr/gpio_isr.c)
 
-if("${IDF_VERSION_MAJOR}.${IDF_VERSION_MINOR}" VERSION_LESS "5.3")
+if (CONFIG_SOC_WIFI_SUPPORTED OR CONFIG_ESP_HOSTED_ENABLED)
+    list(APPEND COMPONENT_SRCS  ./periph_wifi.c)
+endif()
+
+if("${IDF_VERSION_MAJOR}.${IDF_VERSION_MINOR}" VERSION_LESS "5.4")
     list(APPEND COMPONENT_SRCS  ./driver/i2c_bus/i2c_bus.c)
 else()
     list(APPEND COMPONENT_SRCS  ./driver/i2c_bus/i2c_bus_v2.c)
diff --git a/components/wifi_service/CMakeLists.txt b/components/wifi_service/CMakeLists.txt
index fc2f5f9e6..546c3a790 100644
--- a/components/wifi_service/CMakeLists.txt
+++ b/components/wifi_service/CMakeLists.txt
@@ -11,12 +11,14 @@ if (idf_version VERSION_GREATER_EQUAL "5.0")
 list(APPEND COMPONENT_REQUIRES esp_timer)
 endif()
 
+if (CONFIG_SOC_WIFI_SUPPORTED OR CONFIG_ESP_HOSTED_ENABLED)
 list(APPEND COMPONENT_SRCS src/esp_wifi_setting.c
                     src/wifi_service.c
                     src/wifi_ssid_manager.c
                     smart_config/smart_config.c
                     blufi_config/blufi_config.c
                     blufi_config/blufi_security.c)
+endif()
 
 IF (CONFIG_IDF_TARGET STREQUAL "esp32c3" OR CONFIG_IDF_TARGET STREQUAL "esp32c6" OR CONFIG_IDF_TARGET STREQUAL "esp32p4" OR CONFIG_IDF_TARGET STREQUAL "esp32c5")
     register_component()

[ftab]

Tried that, now got this:

In file included from /Users/mac/esp/esp-adf/components/wifi_service/include/wifi_ssid_manager.h:31,
                 from /Users/mac/esp/esp-adf/components/wifi_service/src/wifi_service.c:37:
/Users/mac/esp/esp-adf/components/wifi_service/src/wifi_service.c: In function 'wifi_sta_setup':
/Users/mac/esp/esp-adf/esp-idf/components/esp_wifi/include/esp_wifi.h:311:26: error: 'CONFIG_ESP_WIFI_STATIC_RX_BUFFER_NUM' undeclared (first use in this function); did you mean 'CONFIG_ETH_DMA_RX_BUFFER_NUM'?
  311 |     .static_rx_buf_num = CONFIG_ESP_WIFI_STATIC_RX_BUFFER_NUM,\
      |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

audio_stream requires esp_actions

esp_actions requires dueros_service and wifi_service

dueros_service also requires wifi_service

I tried making a similar edit to components/dueros_service/CMakeLists.txt and components/esp_actions/CMakeLists.txt, and it's still happening... can't tell what is causing it to require dueros_service or wifi_service. I need a dependency graph of some sort, is that possible to generate?

[ftab]

diff --git a/components/dueros_service/CMakeLists.txt b/components/dueros_service/CMakeLists.txt
index fcf5b701..d3754731 100644
--- a/components/dueros_service/CMakeLists.txt
+++ b/components/dueros_service/CMakeLists.txt
@@ -1,3 +1,8 @@
+if( NOT CONFIG_ESP_WIFI_ENABLED
+    AND NOT CONFIG_ESP_HOST_WIFI_ENABLED )
+    return()
+endif()
+
 set(COMPONENT_ADD_INCLUDEDIRS include)
 
 # Edit following two lines to set component requirements (see docs)
diff --git a/components/esp_actions/CMakeLists.txt b/components/esp_actions/CMakeLists.txt
index c31a8040..ff2fd136 100644
--- a/components/esp_actions/CMakeLists.txt
+++ b/components/esp_actions/CMakeLists.txt
@@ -2,14 +2,20 @@ set(COMPONENT_ADD_INCLUDEDIRS include)
 
 # Edit following two lines to set component requirements (see docs)
 set(COMPONENT_REQUIRES audio_sal nvs_flash spi_flash)
-set(COMPONENT_PRIV_REQUIRES esp_dispatcher wifi_service display_service esp-adf-libs audio_pipeline audio_sal dueros_service audio_recorder)
+set(COMPONENT_PRIV_REQUIRES esp_dispatcher display_service esp-adf-libs audio_pipeline audio_sal audio_recorder)
+
+if (CONFIG_SOC_WIFI_SUPPORTED OR CONFIG_ESP_HOSTED_ENABLED)
+    list(APPEND COMPONENT_PRIV_REQUIRES wifi_service dueros_service)
+endif()
 
 set(COMPONENT_SRCS ./display_action.c
-                    ./dueros_action.c
                     ./player_action.c
                     ./recorder_action.c
-                    ./wifi_action.c
                     ./nvs_action.c
                     ./partition_action.c)
 
+if (CONFIG_SOC_WIFI_SUPPORTED OR CONFIG_ESP_HOSTED_ENABLED)
+    list(APPEND COMPONENT_SRCS  ./dueros_action.c ./wifi_action.c)
+endif()
+
 register_component()
diff --git a/components/wifi_service/CMakeLists.txt b/components/wifi_service/CMakeLists.txt
index fc2f5f9e..326b8521 100644
--- a/components/wifi_service/CMakeLists.txt
+++ b/components/wifi_service/CMakeLists.txt
@@ -1,3 +1,8 @@
+if( NOT CONFIG_ESP_WIFI_ENABLED
+    AND NOT CONFIG_ESP_HOST_WIFI_ENABLED )
+    return()
+endif()
+
 set(idf_version "${IDF_VERSION_MAJOR}.${IDF_VERSION_MINOR}")
 
 set(COMPONENT_ADD_INCLUDEDIRS include)

This seems to make it build. no idea if dueros_service still works on apps that actually depend on it, though; I've never used it

[ftab]

+if (CONFIG_SOC_WIFI_SUPPORTED OR CONFIG_ESP_HOSTED_ENABLED)
+    list(APPEND COMPONENT_PRIV_REQUIRES wifi_service dueros_service)
+endif()

Just tried to build for a target that does have WiFi and found out I can't do this (espressif/esp-idf#16002 (comment))

So I can't have it both ways. I either have to have an ESP-ADF that has wifi_service and dueros_service explicitly listed in PRIV_REQUIRES, or it is explicitly excluded. Can't have it both ways depending on Kconfig. Hmmmm...have to wait for IDF 6.0 I guess, or figure out some way to do this by IDF_TARGET only...which won't work with P4 projects that have hosted wireless chips.

[TempoTian]

I have commit code to CI build pipeline use previous mentioned patch, it build success for all examples. The patch not build wifi_service source code at all, instead of change component dependency module CMakeLists.txt on it. I think it can meet your request, if not use wifi on P4. I see your attached build error log, I think you may missing add following options.

+if (CONFIG_SOC_WIFI_SUPPORTED OR CONFIG_ESP_HOSTED_ENABLED)
 list(APPEND COMPONENT_SRCS src/esp_wifi_setting.c
                     src/wifi_service.c
                     src/wifi_ssid_manager.c
                     smart_config/smart_config.c
                     blufi_config/blufi_config.c
                     blufi_config/blufi_security.c)
+endif()