Fix name copy (#907)

limit checks
updated benchmarks
fix name drawing
fixes for dll build
updated 7950x benchmarks
updated readme
updated batch file
SSE2/Neon is now default with no compiler defines
disable warnings as errors for external libraries (glfw)
added dynamic builds to GitHub actions
#909
#910

Author: erincatto

.github/workflows/build.yml

@@ -84,8 +84,8 @@ jobs:
       working-directory: ${{github.workspace}}/build
       run: ./bin/${{env.BUILD_TYPE}}/test
 
-  samples-windows:
-    name: samples-windows
+  samples-windows-static:
+    name: samples-windows-static
     runs-on: windows-latest
     steps:
 
@@ -101,9 +101,27 @@ jobs:
 
     - name: Build
       run: cmake --build ${{github.workspace}}/build --config Release
+
+  samples-windows-dynamic:
+    name: samples-windows-dynamic
+    runs-on: windows-latest
+    steps:
+
+    - uses: actions/checkout@v4
+
+    - name: Setup MSVC dev command prompt
+      uses: TheMrMilchmann/setup-msvc-dev@v3
+      with:
+        arch: x64
+
+    - name: Configure CMake
+      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=Release -DBOX2D_SAMPLES=ON -DBUILD_SHARED_LIBS=ON -DBOX2D_UNIT_TESTS=OFF
 
-  samples-macos:
-    name: samples-macos
+    - name: Build
+      run: cmake --build ${{github.workspace}}/build --config Release
+
+  samples-macos-static:
+    name: samples-macos-static
     runs-on: macos-latest
 
     steps:
@@ -114,3 +132,16 @@ jobs:
 
     - name: Build
       run: cmake --build ${{github.workspace}}/build --config Release
+
+  samples-macos-dynamic:
+    name: samples-macos-dynamic
+    runs-on: macos-latest
+
+    steps:
+    - uses: actions/checkout@v4
+
+    - name: Configure CMake
+      run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=Release -DBOX2D_SAMPLES=ON -DBUILD_SHARED_LIBS=ON -DBOX2D_UNIT_TESTS=OFF
+      
+    - name: Build
+      run: cmake --build ${{github.workspace}}/build --config Release

CMakeLists.txt

@@ -31,8 +31,6 @@ if (MSVC OR APPLE)
 			add_compile_options("$<$<CONFIG:Debug>:/fsanitize=address>")
 			add_link_options("$<$<CONFIG:Debug>:/INCREMENTAL:NO>")
 		elseif(APPLE)
-			# more sanitizers on Apple clang
-			# add_compile_options(-fsanitize=thread -fno-omit-frame-pointer)
 			add_compile_options(-fsanitize=address -fsanitize-address-use-after-scope -fsanitize=undefined)
 			add_link_options(-fsanitize=address -fsanitize-address-use-after-scope -fsanitize=undefined)
 		endif()
@@ -47,22 +45,24 @@ endif()
 
 # Deterministic math
 # https://box2d.org/posts/2024/08/determinism/
-# todo make this apply to ClangCL
 if (MINGW OR APPLE OR UNIX)
 	add_compile_options(-ffp-contract=off)
 endif()
 
-option(BOX2D_ENABLE_SIMD "Enable SIMD math (faster)" ON)
+option(BOX2D_DISABLE_SIMD "Disable SIMD math (slower)" OFF)
 
 if(CMAKE_SYSTEM_PROCESSOR MATCHES "x86_64|AMD64")
-	cmake_dependent_option(BOX2D_AVX2 "Enable AVX2" OFF "BOX2D_ENABLE_SIMD" OFF)
+	cmake_dependent_option(BOX2D_AVX2 "Enable AVX2" OFF "NOT BOX2D_DISABLE_SIMD" OFF)
 endif()
 
-set(CMAKE_COMPILE_WARNING_AS_ERROR ON)
 set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
 set_property(GLOBAL PROPERTY USE_FOLDERS ON)
 set(CMAKE_VERBOSE_MAKEFILE ON)
 
+# Needed for samples.exe to find box2d.dll
+set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/bin")
+set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/bin")
+
 add_subdirectory(src)
 
 # This hides samples, test, and doxygen from apps that use box2d via FetchContent
@@ -74,17 +74,6 @@ if(PROJECT_IS_TOP_LEVEL)
 	option(BOX2D_VALIDATE "Enable heavy validation" ON)
 	option(BOX2D_UNIT_TESTS "Build the Box2D unit tests" ON)
 
-	# Needed for samples.exe to find box2d.dll
-	# set(CMAKE_LIBRARY_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/bin")
-	set(CMAKE_RUNTIME_OUTPUT_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}/bin")
-
-	include(GNUInstallDirs)
-
-	install(
-		DIRECTORY "${CMAKE_CURRENT_SOURCE_DIR}/include/box2d"
-		DESTINATION ${CMAKE_INSTALL_INCLUDEDIR}
-	)
-
 	if(MSVC AND WIN32)
 		# add_compile_options(/fsanitize=address)
 		# set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "/GS- /Gy /O2 /Oi /Ot")

README.md

@@ -12,11 +12,12 @@ Box2D is a 2D physics engine for games.
 
 ### Collision
 - Continuous collision detection
-- Contact events and sensors
+- Contact events
 - Convex polygons, capsules, circles, rounded polygons, segments, and chains
 - Multiple shapes per body
 - Collision filtering
 - Ray casts, shape casts, and overlap queries
+- Sensor system
 
 ### Physics
 - Robust _Soft Step_ rigid body solver
@@ -31,19 +32,22 @@ Box2D is a 2D physics engine for games.
 - Data-oriented design
 - Written in portable C17
 - Extensive multithreading and SIMD
+- Optimized for large piles of bodies
 
 ### Samples
 - OpenGL with GLFW and enkiTS
 - Graphical user interface with imgui
 - Many samples to demonstrate features and performance
 
-## Building
+## Building for Visual Studio
 - Install [CMake](https://cmake.org/)
 - Ensure CMake is in the user `PATH`
-- Visual Studio: run `build.bat` from the command prompt
-- Otherwise: run `build.sh` from a bash shell
+- Run `create_sln.bat`
+- Open and build `build/box2d.sln`
+
+## Building for Linux
+- Run `build.sh` from a bash shell
 - Results are in the build sub-folder
-- On Windows you can open box2d.sln
 
 ## Building for Xcode
 - Install [CMake](https://cmake.org)
@@ -52,15 +56,25 @@ Box2D is a 2D physics engine for games.
 - mkdir build
 - cd build
 - cmake -G Xcode ..
-- open box2d.xcodeproj
+- Open `box2d.xcodeproj`
 - Select the samples scheme
-- Edit the scheme to set a custom working directory to the box2d directory
-- You can now build and run the samples
+- Build and run the samples
+
+## Building and installing
+- mkdir build
+- cd build
+- cmake ..
+- cmake --build . --config Release
+- cmake --install . (might need sudo)
 
 ## Compatibility
 The Box2D library and samples build and run on Windows, Linux, and Mac.
 
-Box2D should be built on recent versions of clang and gcc. You will need the latest Visual Studio version for C11 atomics to compile (17.8.3+).
+You will need a compiler that supports C17 to build the Box2D library.
+
+You will need a compiler that supports C++20 to build the samples.
+
+Box2D uses SSE2 and Neon SIMD math to improve performance. This can be disabled by defining `BOX2D_DISABLE_SIMD`.
 
 ## Documentation
 - [Manual](https://box2d.org/documentation/)
@@ -73,7 +87,7 @@ Box2D should be built on recent versions of clang and gcc. You will need the lat
 Please do not submit pull requests. Instead, please file an issue for bugs or feature requests. For support, please visit the Discord server.
 
 # Giving Feedback
-Please file an issue or start a chat on discord.
+Please file an issue or start a chat on discord. You can also use [GitHub Discussions](https://github.com/erincatto/box2d/discussions).
 
 ## License
 Box2D is developed by Erin Catto and uses the [MIT license](https://en.wikipedia.org/wiki/MIT_License).
@@ -83,7 +97,7 @@ Support development of Box2D through [Github Sponsors](https://github.com/sponso
 
 Please consider starring this repository and subscribing to my [YouTube channel](https://www.youtube.com/@erin_catto).
 
-## Ports, wrappers, and bindings
+## External ports, wrappers, and bindings (unsupported)
 - Beef bindings - https://github.com/EnokViking/Box2DBeef
 - C++ bindings - https://github.com/HolyBlackCat/box2cpp
 - WASM - https://github.com/Birch-san/box2d3-wasm

benchmark/CMakeLists.txt

@@ -5,7 +5,12 @@ set(BOX2D_BENCHMARK_FILES
 )
 add_executable(benchmark ${BOX2D_BENCHMARK_FILES})
 
-set_target_properties(benchmark PROPERTIES C_STANDARD 17)
+set_target_properties(benchmark PROPERTIES
+    C_STANDARD 17
+    C_STANDARD_REQUIRED YES
+    C_EXTENSIONS NO
+	COMPILE_WARNING_AS_ERROR ON
+)
 
 target_link_libraries(benchmark PRIVATE box2d shared enkiTS)
 

benchmark/amd7950x_avx2/joint_grid.csv

@@ -1,9 +1,9 @@
 threads,ms
-1,2528.51
-2,1460.58
-3,1004.38
-4,822.484
-5,712.691
-6,638.201
-7,583.016
-8,540.158
+1,3174.52
+2,1795.2
+3,1217.45
+4,996.27
+5,857.203
+6,763.975
+7,696.29
+8,648.49

benchmark/amd7950x_avx2/large_pyramid.csv

@@ -1,9 +1,9 @@
 threads,ms
-1,1579.54
-2,849.264
-3,591.984
-4,466.064
-5,393.207
-6,347.593
-7,305.863
-8,305.205
+1,1951.88
+2,1026.26
+3,721.553
+4,563.934
+5,473.542
+6,415.048
+7,367.646
+8,362.217

benchmark/amd7950x_avx2/many_pyramids.csv

@@ -1,9 +1,9 @@
 threads,ms
-1,2592.03
-2,1412.01
-3,953.71
-4,731.394
-5,601.527
-6,511.144
-7,441.201
-8,393.566
+1,3312.37
+2,1674.87
+3,1116.48
+4,859.268
+5,691.412
+6,594.236
+7,513.412
+8,462.289

benchmark/amd7950x_avx2/rain.csv

@@ -1,9 +1,9 @@
 threads,ms
-1,6462.19
-2,3806.63
-3,2907
-4,2413.23
-5,2069.53
-6,1852.14
-7,1671.47
-8,1547.16
+1,8415.32
+2,4830.51
+3,3684.98
+4,3008.05
+5,2568.19
+6,2275.1
+7,2054.01
+8,1896.27

benchmark/amd7950x_avx2/smash.csv

@@ -1,9 +1,9 @@
 threads,ms
-1,1533.42
-2,981.749
-3,763.27
-4,642.928
-5,574.053
-6,527.394
-7,492.883
-8,468.971
+1,1946.15
+2,1212.81
+3,937.648
+4,786.533
+5,699.338
+6,636.796
+7,597.153
+8,564.691

benchmark/amd7950x_avx2/spinner.csv

@@ -1,9 +1,9 @@
 threads,ms
-1,4126.1
-2,2491.09
-3,1918.78
-4,1543.11
-5,1360.84
-6,1216.53
-7,1110.95
-8,1043.96
+1,5145.33
+2,3090.7
+3,2362.34
+4,1890.21
+5,1643.82
+6,1473.02
+7,1339.32
+8,1256.21