Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 24, 2025

Thanks for assigning this issue to me. I'm starting to work on it and will keep this PR's description up to date as I form a plan and make progress.

Original prompt

This section details on the original issue you should resolve

<issue_title>different results from frame_grabber and frame_grabber_node #grab</issue_title>
<issue_description>Per comment #190 (comment)

It appears that there are differences in the output of the grab() function in frame_grabber and frame_grabber_node, which appear to be usually minor, but enough to make a difference between success and failure on fixtures/code_39/image_010.

In browser:

image

in node:

image
</issue_description>

<agent_instructions>Any chance you could analyze the grab functions and relatives in frame_grabber and frame_grabber_node and figure out why there's a difference in the numbers at various points? or have we already solved it likely? the test files mentioned in this issue #191 are mostly still failing, even after the fixes we've performed in the last few days.
</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@ericblade ... it looks like we get the same size array, but the data inside it is all slightly off. not sure if there's an offset, or if there's just straight up some differences in the data coming out. they go through what appear to be vastly different processes during their #grab functions.. so these internals need to be validated against each other, it would seem. @ericblade This problem also seems to affect ean_8, test file 004, which fails in cypress, but succeeds in node. Curiously, it worked in PhantomJS. I've long suspected that there may be some issues with code in Quagga being non-deterministic altering potential results, and that may be an issue here. @ericblade Codabar image-008 also @ericblade new test Code_39 #11 illustrates this also

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

@rollingversions
Copy link

There is no change log for this pull request yet.

Create a changelog

@github-actions
Copy link
Contributor

Thank you for issuing a pull request! Open source works best when we all work together! Please make sure you have added yourself to the contributors array in package.json. If you dont hear from anyone within a few days, please ping, I have a day job and a family that keeps me busy, and I sometimes miss Github notifications. Have a great day!

@ericblade
Copy link
Owner

@copilot are you stuck after that stop? Or do I need to issue another issue or PR to get this kicked off?

Copy link
Owner

@ericblade ericblade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This whole PR seems to be just stuck, and nothing happening?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

different results from frame_grabber and frame_grabber_node #grab

2 participants