test: add integration tests for on_demand VHDS with request bodies #42248
+208
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wdauchy
force-pushed
the
vhds-test
branch
29 times, most recently
from
e4672b7 to
ed732e5
Compare
wdauchy
force-pushed
the
vhds-test
branch
5 times, most recently
from
0e738ed to
9ac4ca9
Compare
botengyao
reviewed
Dec 1, 2025
Member
botengyao
left a comment
botengyao
left a comment
There was a problem hiding this comment.
thanks for adding the integration test!
/wait
| TEST_P(OnDemandVhdsWithBodyIntegrationTest, VhdsOnDemandUpdateWithBody) { | ||
| // Skip Unified mux - it doesn't properly handle on-demand VHDS updates. | ||
| const bool is_unified_mux = | ||
| std::get<2>(std::get<1>(GetParam())) == Grpc::LegacyOrUnified::Unified; |
Member
There was a problem hiding this comment.
What is the reason that unified client doesn't handle it properly?
Contributor
Author
There was a problem hiding this comment.
it is a bad wording I used. I was unable to make it work so far, I am getting a timeout all the time (a race in the setup?). so I thought I would first propose an initial step.
Member
There was a problem hiding this comment.
nit: mind adding TODO(wdauchy)? just to keep it be consistent with other places, and it is okay that others pick up as well
Add integration tests verifying VHDS on-demand updates work correctly with request bodies for both HTTP/1.1 and HTTP/2. The tests use HttpProtocolIntegrationTest parameterization to automatically run for both downstream protocols (HTTP/1.1 and HTTP/2), ensuring the fix for envoyproxy#17891 works correctly across different HTTP protocol versions. Tests verify that: - Request bodies are preserved when triggering on-demand VHDS updates - Stream recreation works correctly after VHDS updates complete - Both HTTP/1.1 and HTTP/2 protocols handle bodies correctly The test instantiation uses getProtocolTestParamsWithoutHTTP3() which returns parameter combinations for both HTTP/1.1 and HTTP/2 downstream protocols, so each test runs multiple times (once per protocol combination). Complements the unit tests in d39afea and provides end-to-end verification for envoyproxy#17891. Risk Level: Low Testing: New integration tests parameterized for HTTP/1.1 and HTTP/2 Signed-off-by: William Dauchy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Add integration tests verifying VHDS on-demand updates work correctly with request bodies for both HTTP/1.1 and HTTP/2. The tests use HttpProtocolIntegrationTest parameterization to automatically run for both downstream protocols (HTTP/1.1 and HTTP/2), ensuring the fix for #17891 works correctly across different HTTP protocol versions.
Additional Description:
Tests verify that:
The test instantiation uses getProtocolTestParamsWithoutHTTP3() which returns parameter combinations for both HTTP/1.1 and HTTP/2 downstream protocols, so each test runs multiple times (once per protocol combination).
Complements the unit tests in d39afea and provides end-to-end verification for #17891.
followup of #42158
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]