Skip to content

Commit 52b9192

Browse files
committed
add notes for tooling team 20th May
1 parent b1ac074 commit 52b9192

File tree

1 file changed

+99
-0
lines changed

1 file changed

+99
-0
lines changed

st-embroider/2024/2025-05-20.md

Lines changed: 99 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,99 @@
1+
# 2025-05-20
2+
3+
Note Taker: Chris Manson
4+
Time Keeper: Chris Manson
5+
6+
## Attendees
7+
8+
Add yourself to the list if you attend and check the box!
9+
10+
- [x] Ed Faulkner (EF)
11+
- [x] Chris Manson (CM)
12+
- [x] Alex (A)
13+
- [x] Preston Sego (PS)
14+
- [ ] Simon Ihmig (SI)
15+
- [x] Katie Gengler (KG)
16+
- [ ] Peter Meehan (PM)
17+
- [ ] Krystan HuffMenne (KH)
18+
- [ ] Peter Wagenet (PW)
19+
- [ ] James Davis (JD)
20+
- [x] Patricklx
21+
- [x] robbytx
22+
- [x] tommyjr
23+
- [x] Lucas.vs
24+
- [x] nickschot
25+
26+
## Topics
27+
28+
### Project Planning
29+
30+
- type=module quest - PS: I will re-run all the reproductions to check the current state of things
31+
32+
### @embroider/util PR - https://github.com/embroider-build/embroider/pull/2480 <@NullVoxPopuli>
33+
34+
- EF: I thought I deleted this
35+
- CM: no we just made it private so we don't release
36+
- PS: I will PR deleting this
37+
38+
### Fixing regexes for splitAtRoutes https://github.com/embroider-build/embroider/pull/2458 <@mansona>
39+
40+
- (worked on it in office hours)
41+
- CM: I made the suggested fix
42+
- EF: merged
43+
44+
### importSync is overly eager - https://github.com/embroider-build/embroider/issues/2471 macros issue
45+
46+
- (discussion)
47+
- EF: chris commented on this, do we need to do anything else
48+
- CM: we really should not do anything until the known problem is fixed
49+
- (all agree)
50+
- EF: we really need to make it clear that `@embroider/macros` should be used very sparingly as a means to get over a non-breaking migration but we should be moving to `import()` apis going forward
51+
52+
53+
### Test scenarios failures on Windows with newer Ember Data <robbytx>
54+
55+
- https://github.com/embroider-build/embroider/pull/2473
56+
- (long discussion)
57+
- It turns out that in mac and linux vite deps are considered with the owner as the app
58+
- on windows this isn't the case (for some reason)
59+
- This is what throws the error: https://github.com/embroider-build/embroider/blob/main/packages/macros/src/babel/state.ts#L81-L87
60+
- EF: in this case (for ember-data) it is an opertunistic check and shouldn't throw
61+
- the solution is to go through the code and see what is using the function `owningPackage()`
62+
63+
64+
### type=module by default in both addon and app <@NullVoxPopuli>
65+
66+
- PS: it works for new apps and addons
67+
- EF: does it work if you use macros with vite?
68+
- we need to update the original issue to make sure we know what works and what doesn't
69+
- PS: I will update the issue
70+
71+
72+
### PRs <@NullVoxPopuli>
73+
https://github.com/ember-cli/ember-app-blueprint/pull/15
74+
https://github.com/ember-cli/ember-app-blueprint/pull/11
75+
https://github.com/ember-cli/ember-app-blueprint/pull/12
76+
https://github.com/ember-cli/ember-app-blueprint/pull/13
77+
https://github.com/ember-cli/ember-app-blueprint/pull/14
78+
https://github.com/ember-cli/ember-addon-blueprint/pull/41
79+
https://github.com/ember-cli/ember-addon-blueprint/pull/40
80+
https://github.com/ember-cli/ember-addon-blueprint/pull/39
81+
https://github.com/ember-cli/ember-addon-blueprint/pull/38
82+
https://github.com/ember-cli/ember-addon-blueprint/pull/6
83+
CI bot that posts to Discord?
84+
85+
- discussion about which of these is controvercial
86+
- a lot of these don't need group discussion
87+
-
88+
89+
### Discussion about gjs as default before generators can provide the same https://github.com/ember-cli/ember-app-blueprint/pull/11 <@mansona>
90+
91+
- (all agreed that we can target beta)
92+
- KG: we would need the feature to get `--strict` to target route files
93+
- CM: very strongly agree
94+
- (all agreed)
95+
96+
<5 mins> what needs to happen for bpetc @ v3? https://github.com/ember-cli/ember-app-blueprint/pull/9 <@NullVoxPopuli>
97+
<5 mins> runtime version of @embroider/macros/babel? Possible? <@NullVoxPopuli>
98+
99+

0 commit comments

Comments
 (0)