[doc] Common error, forgetting _super in included

[mike-north]

Over the past couple of weeks, I've worked with a few people to get JS decorators working in existing ember addons. The most common setup snag that people hit was forgetting to call this._super in an existing included() hook.

We may want to add a note about this in the docs, to ensure that getting set up is as easy as possible.

[rwjblue]

Ya, we can even check their index.js upon installation to confirm...

[pzuraq]

👍 all for adding it, it should be this._super.included.apply(this, arguments) though right? Or this._super.included(...arguments) if that is within the node version range we intend to support. I've been bitten by that one before as well.

[mike-north]

I only meant to point out the need to call _super.

[dfreeman]

this._super.included.apply(this, arguments) is semantically different from this._super.included(...arguments) — the latter winds up with the super fn as this, so I believe it'll need to be the former regardless of spread support

[BryanCrotaz]

can this be added to the ember linting?

[buschtoens]

I think the eslint-plugin-ember is only for js source files that get bundled into the app, and not for node source files. :/