Add H264 RTP depayloader #224
Conversation
brzep
force-pushed
the
brzep/h264-depayloader
branch
from
646eb37 to
aeea29d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 87.79% 88.08% +0.29%
==========================================
Files 54 59 +5
Lines 2752 2804 +52
==========================================
+ Hits 2416 2470 +54
+ Misses 336 334 -2
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
brzep
force-pushed
the
brzep/h264-depayloader
branch
from
3eb806f to
43407a3
Compare
There was a problem hiding this comment.
It would be nice if we could add tests for the other modules (fu, fu/header, stap_a, nal_header), like in test/rtp/vp8/payload_test.exs or test/rtp/av1/ as well. But I won't push for this, as we have other things on the roadmap -- if @mickel8 approves, you can merge 👍
| @moduledoc """ | ||
| Module responsible for parsing H264 Fragmentation Unit. | ||
| """ |
There was a problem hiding this comment.
Let's change the other moduledocs to comments as well
|
|
||
| defp do_depayload(:stap_a, depayloader, packet, {_header, payload}) do | ||
| with {:ok, result} <- StapA.parse(payload) do | ||
| nals = result |> Stream.map(&prefix_annexb/1) |> Enum.join() |
There was a problem hiding this comment.
sorry, completely forgot about the existence of Enum.map_join/2 xdd
we can use that instead
Depayloads H264 from RTP. Supports following NALU types: Single NALU, STAP-A, FU-A.