Skip to content

Email notifications show broken images (due to authenticated media) #17832

Open
@turt2live

Description

@turt2live

Description

Reported on behalf of a conversation I saw: Email notifications use the legacy, unauthenticated, and deprecated URLs for avatars of rooms/senders, which don't work when authenticated media is in full force. This leads to the "broken image" placeholder in browsers/email clients.

The easiest fix is to remove the img elements entirely, as it's questionable to include them from a Trust & Safety perspective anyways (at least until there's better tooling available). Magic URLs like how bridges work may be desirable in the long term.

Steps to reproduce

  • receive an email notification

Homeserver

matrix.org

Synapse Version

whatever matrix.org runs

Installation Method

Other (please mention below)

Database

postgresql

Workers

Single process

Platform

matrix.org

Configuration

No response

Relevant log output

see matrix.org

Anything else that would be useful to know?

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions