logger.throw

Author: alexanderkirtzel

packages/server/destinations/aws/src/firehose/index.ts

@@ -11,10 +11,11 @@ export const destinationFirehose: Destination = {
 
   config: {},
 
-  async init({ config: partialConfig, env }) {
+  async init({ config: partialConfig, env, logger }) {
     const config = getConfig(partialConfig, env);
 
-    if (!isSameType(config.settings, {} as Settings)) return false;
+    if (!isSameType(config.settings, {} as Settings))
+      logger.throw('Config settings invalid');
 
     return config;
   },

packages/server/destinations/datamanager/src/config.ts

@@ -1,12 +1,15 @@
 import type { Config, Settings, PartialConfig } from './types';
-import { throwError } from '@walkeros/core';
+import type { Logger } from '@walkeros/core';
 
-export function getConfig(partialConfig: PartialConfig = {}): Config {
+export function getConfig(
+  partialConfig: PartialConfig = {},
+  logger: Logger.Instance,
+): Config {
   const settings = (partialConfig.settings || {}) as Partial<Settings>;
   const { destinations } = settings;
 
   if (!destinations || destinations.length === 0)
-    throwError('Config settings destinations missing or empty');
+    logger.throw('Config settings destinations missing or empty');
 
   const settingsConfig: Settings = {
     ...settings,

packages/server/destinations/datamanager/src/index.ts

@@ -10,18 +10,18 @@ export const destinationDataManager: DestinationInterface = {
 
   config: {},
 
-  async init({ config: partialConfig, env }) {
-    const config = getConfig(partialConfig);
+  async init({ config: partialConfig, env, logger }) {
+    const config = getConfig(partialConfig, logger);
 
     if (!config.settings) {
-      throw new Error('Settings required for Data Manager destination');
+      logger.throw('Settings required for Data Manager destination');
     }
 
     if (
       !config.settings.destinations ||
       config.settings.destinations.length === 0
     ) {
-      throw new Error('At least one destination required in settings');
+      logger.throw('At least one destination required in settings');
     }
 
     try {
@@ -35,7 +35,7 @@ export const destinationDataManager: DestinationInterface = {
         },
       };
     } catch (error) {
-      throw new Error(
+      logger.throw(
         `Data Manager authentication failed: ${error instanceof Error ? error.message : 'Unknown error'}`,
       );
     }

packages/server/destinations/gcp/src/bigquery/config.ts

@@ -1,17 +1,18 @@
 import type { Config, Env, PartialConfig, Settings } from './types';
 import type { BigQueryOptions } from '@google-cloud/bigquery';
-import { throwError } from '@walkeros/core';
+import type { Logger } from '@walkeros/core';
 import { BigQuery } from '@google-cloud/bigquery';
 
 export function getConfig(
   partialConfig: PartialConfig = {},
-  env?: Env,
+  env: Env | undefined,
+  logger: Logger.Instance,
 ): Config {
   const settings = partialConfig.settings || ({} as Settings);
   const { projectId, bigquery } = settings;
   let { client, location, datasetId, tableId } = settings;
 
-  if (!projectId) throwError('Config settings projectId missing');
+  if (!projectId) logger.throw('Config settings projectId missing');
 
   location = location || 'EU';
   datasetId = datasetId || 'walkeros';

packages/server/destinations/gcp/src/bigquery/index.ts

@@ -10,8 +10,8 @@ export const destinationBigQuery: Destination = {
 
   config: {},
 
-  async init({ config: partialConfig, env }) {
-    const config = getConfig(partialConfig, env);
+  async init({ config: partialConfig, env, logger }) {
+    const config = getConfig(partialConfig, env, logger);
 
     return config;
   },

packages/server/destinations/meta/src/config.ts

@@ -1,12 +1,15 @@
 import type { Config, Settings, PartialConfig } from './types';
-import { throwError } from '@walkeros/core';
+import type { Logger } from '@walkeros/core';
 
-export function getConfig(partialConfig: PartialConfig = {}): Config {
+export function getConfig(
+  partialConfig: PartialConfig = {},
+  logger: Logger.Instance,
+): Config {
   const settings = (partialConfig.settings || {}) as Partial<Settings>;
   const { accessToken, pixelId } = settings;
 
-  if (!accessToken) throwError('Config settings accessToken missing');
-  if (!pixelId) throwError('Config settings pixelId missing');
+  if (!accessToken) logger.throw('Config settings accessToken missing');
+  if (!pixelId) logger.throw('Config settings pixelId missing');
 
   const settingsConfig: Settings = {
     ...settings,

packages/server/destinations/meta/src/index.ts

@@ -10,8 +10,8 @@ export const destinationMeta: Destination = {
 
   config: {},
 
-  async init({ config: partialConfig }) {
-    const config = getConfig(partialConfig);
+  async init({ config: partialConfig, logger }) {
+    const config = getConfig(partialConfig, logger);
     return config;
   },
 

packages/web/destinations/api/src/index.test.ts

@@ -15,6 +15,9 @@ describe('Destination API', () => {
   const testEnv = clone(examples.env.push);
   testEnv.sendWeb = mockSendWeb;
 
+  // Mock logger
+  const mockLogger = createMockLogger();
+
   beforeEach(async () => {
     jest.clearAllMocks();
 
@@ -26,21 +29,23 @@ describe('Destination API', () => {
   });
 
   test('init', () => {
-    // Test with no URL - should not call sendWeb
-    destination.push(event, {
-      collector: {} as Collector.Instance,
-      config: {},
-      env: testEnv,
-      logger: createMockLogger(),
-    });
+    // Test with no URL - should throw error
+    expect(() =>
+      destination.push(event, {
+        collector: {} as Collector.Instance,
+        config: {},
+        env: testEnv,
+        logger: mockLogger,
+      }),
+    ).toThrow('Config settings url missing');
     expect(mockSendWeb).not.toHaveBeenCalled();
 
     // Test with URL - should call sendWeb
     destination.push(event, {
       collector: {} as Collector.Instance,
       config: { settings: { url } },
       env: testEnv,
-      logger: createMockLogger(),
+      logger: mockLogger,
     });
     expect(mockSendWeb).toHaveBeenCalledTimes(1);
 
@@ -64,7 +69,7 @@ describe('Destination API', () => {
         settings: { url },
       },
       env: customEnv,
-      logger: createMockLogger(),
+      logger: mockLogger,
     });
 
     expect(customSendWeb).toHaveBeenCalledTimes(1);
@@ -85,7 +90,7 @@ describe('Destination API', () => {
         settings: { url, transform: () => 'transformed' },
       },
       env: testEnv,
-      logger: createMockLogger(),
+      logger: mockLogger,
     });
     expect(mockSendWeb).toHaveBeenCalledWith(
       url,
@@ -101,7 +106,7 @@ describe('Destination API', () => {
         settings: { url, headers: { foo: 'bar' } },
       },
       env: testEnv,
-      logger: createMockLogger(),
+      logger: mockLogger,
     });
     expect(mockSendWeb).toHaveBeenCalledWith(
       url,
@@ -119,7 +124,7 @@ describe('Destination API', () => {
         settings: { url, method: 'POST' },
       },
       env: testEnv,
-      logger: createMockLogger(),
+      logger: mockLogger,
     });
     expect(mockSendWeb).toHaveBeenCalledWith(
       url,
@@ -138,7 +143,7 @@ describe('Destination API', () => {
         mapping: examples.mapping.config,
       },
       env: testEnv,
-      logger: createMockLogger(),
+      logger: mockLogger,
     });
 
     expect(mockSendWeb).toHaveBeenCalledWith(

packages/web/destinations/api/src/index.ts

@@ -10,7 +10,7 @@ export const destinationAPI: Destination = {
 
   config: {},
 
-  push(event, { config, mapping, data, env }) {
+  push(event, { config, mapping, data, env, logger }) {
     const { settings } = config;
     const {
       url,
@@ -20,15 +20,15 @@ export const destinationAPI: Destination = {
       transport = 'fetch',
     } = settings || {};
 
-    if (!url) return;
+    if (!url) logger.throw('Config settings url missing');
 
     const eventData = isDefined(data) ? data : event;
     const body = transform
       ? transform(eventData, config, mapping) // Transform event data
       : JSON.stringify(eventData);
 
     const sendWebFn = (env as Env)?.sendWeb || sendWeb;
-    sendWebFn(url, body, { headers, method, transport });
+    sendWebFn(url!, body, { headers, method, transport });
   },
 };
 

packages/web/destinations/gtag/src/__tests__/ads.test.ts

@@ -1,24 +1,34 @@
 import { initAds, pushAdsEvent } from '../ads';
 import { examples } from '../dev';
-import { clone } from '@walkeros/core';
+import { clone, createMockLogger } from '@walkeros/core';
 import type { AdsSettings, AdsMapping } from '../types';
 
 describe('Google Ads Implementation', () => {
   const mockGtag = jest.fn();
   const mockEnv = clone(examples.env.push);
   mockEnv.window.gtag = mockGtag;
 
+  // Create a mock logger that actually throws
+  const createThrowingLogger = () => {
+    const logger = createMockLogger();
+    logger.throw = (message: string) => {
+      throw new Error(message);
+    };
+    return logger;
+  };
+
   beforeEach(() => {
     jest.clearAllMocks();
   });
 
   describe('initAds', () => {
-    it('should return early if no conversionId', () => {
+    it('should throw error if no conversionId', () => {
       const settings: AdsSettings = { conversionId: '' };
+      const logger = createThrowingLogger();
 
-      initAds(settings, undefined, mockEnv);
-
-      expect(mockGtag).not.toHaveBeenCalled();
+      expect(() => initAds(settings, undefined, mockEnv, logger)).toThrow(
+        'Config settings ads.conversionId missing',
+      );
     });
 
     it('should initialize Ads with basic settings', () => {
@@ -72,10 +82,20 @@ describe('Google Ads Implementation', () => {
       currency: 'EUR',
     };
 
-    it('should return early if no mapping name', () => {
-      pushAdsEvent(mockEvent as any, settings, {}, {}, undefined, mockEnv);
-
-      expect(mockGtag).not.toHaveBeenCalled();
+    it('should throw error if no mapping name', () => {
+      const logger = createThrowingLogger();
+
+      expect(() =>
+        pushAdsEvent(
+          mockEvent as any,
+          settings,
+          {},
+          {},
+          undefined,
+          mockEnv,
+          logger,
+        ),
+      ).toThrow('Config mapping ads.label missing');
     });
 
     it('should push conversion event with correct parameters', () => {
@@ -190,12 +210,21 @@ describe('Google Ads Implementation', () => {
       });
     });
 
-    it('should return early when neither mapping.label nor mappingName is provided', () => {
+    it('should throw error when neither mapping.label nor mappingName is provided', () => {
       const mapping: AdsMapping = {};
-
-      pushAdsEvent(mockEvent as any, settings, mapping, {}, undefined, mockEnv);
-
-      expect(mockGtag).not.toHaveBeenCalled();
+      const logger = createThrowingLogger();
+
+      expect(() =>
+        pushAdsEvent(
+          mockEvent as any,
+          settings,
+          mapping,
+          {},
+          undefined,
+          mockEnv,
+          logger,
+        ),
+      ).toThrow('Config mapping ads.label missing');
     });
   });
 });