EuiPopover Remove arrow pointer

[ryankeairns]

This feels outdated... is it necessary? can we remove it?

Current state

Example from Geist

Alignment considerations

If removed, we may want to limit alignment to edges and not the center (or only use the arrow when aligned center?)
...we have all the alignment options available today.

Possible solutions

1. Never show an arrow but keep center alignment options
2. Never show an arrow and remove center alignment options
3. Only show an arrow on center alignment options
4. Change defaults to hasArrow: false and `anchorPosition: 'downLeft' (make arrow opt-in)
5. Do nothing; leave as-is

[ryankeairns]

@ek-so , et al, if we go with option 4, then we can keep the arrow for use cases that feel it is necessary while largely removing it in one fell swoop.

Also, these options are not mutually exclusive. We could come back and do 1, 2, or 3 later.
Progress over perfection. 1 or 2 could lead to a bevy of alignment discussions and breaking changes whereas 4 may be considered a breaking change but its soft.

[ek-so]

Thanks @ryankeairns for listing those! Some thoughts...

• I don't see why we would want to keep an arrow only for center alignment 🤔 In my view it was, either removing it, or keeping it
• We can also have all the same alignment options, seems to be no prob with that? (Notion example)
• As for leaving arrows, I believe we need to align this decision with the new shadow tokens — because the implementation of the latter might depend on this. In other words, if we really want to keep arrows, we probably better decide it now and let EUI know, so that we can decide on the implementation to show them properly

[ryankeairns]

I don't see why we would want to keep an arrow only for center alignment 🤔 In my view it was, either removing it, or keeping it
We can also have all the same alignment options, seems to be no prob with that? (Notion example)

Ok, let's give it a go.

As for leaving arrows, I believe we need to align this decision with the new shadow tokens — because the implementation of the latter might depend on this. In other words, if we really want to keep arrows, we probably better decide it now and let EUI know, so that we can decide on the implementation to show them properly

Lene replied that it would be simpler to complete the task with arrows as-is. This seems fine and practical while providing us time to sort out exactly what we want here - test it in Kibana, get alignment, etc. That will take time and has no certain outcome, yet.

[ryankeairns]

For the current task of updating shadow tokens, continue as-is with arrows.

For the task of removing the arrows, proceed with Option 1 - Never show an arrow but keep center alignment options

Next steps:

1. Create an issue
2. Draft a PR
3. Test in EUI and Kibana settings
4. Make a final determination on if/how to proceed with the removal of arrows... including impact to shadows, if needed.

[ryankeairns]

Issue is here #8931