-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Log failure in internalSend
#131418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Log failure in internalSend
#131418
Conversation
An exception here should be impossible, but we don't assert that, nor do we emit a log message to prove it didn't happen in a production environment. This commit adds the missing log and assert.
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
I'm suspecting other place that might throw error that we dont catch. Async connect call that we dont check for exceptions. Looking at netty's code path I cannot tell 100% that channel can be null with exception as we assume in the code.
Lines 268 to 274 in e713f7c
|
Possibly, but that wouldn't cause a long-established channel to close. We can address that separately, no need to do so here. |
I opened #131520 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
An exception here should be impossible, but we don't assert that, nor do
we emit a log message to prove it didn't happen in a production
environment. This commit adds the missing log and assert.