Skip to content

Refactor and simplify missing index & unavailability handling #131252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 15, 2025
Merged

Refactor and simplify missing index & unavailability handling #131252

merged 2 commits into from
Jul 15, 2025

Conversation

smalyshev
Copy link
Contributor

  • Make updateExecutionInfoWithUnavailableClusters extract failures directly
  • Make updateExecutionInfoWithClustersWithNoMatchingIndices only check active clusters

@smalyshev smalyshev requested a review from dnhatn July 15, 2025 00:23
@smalyshev smalyshev marked this pull request as ready for review July 15, 2025 00:23
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 15, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

dnhatn
dnhatn approved these changes Jul 15, 2025
View reviewed changes
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@smalyshev smalyshev added v8.9.1 v9.1.0 auto-backport Automatically create backport pull requests when merged labels Jul 15, 2025
@smalyshev smalyshev merged commit 366bc00 into elastic:main Jul 15, 2025
33 checks passed
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.9 Commit could not be cherrypicked due to conflicts
❌ 9.1 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 131252

@smalyshev smalyshev mentioned this pull request Jul 15, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 15, 2025
@smalyshev
Refactor and simplify missing index & unavailability handling (elasti…
7231ccb 
…c#131252)

(cherry picked from commit 366bc00)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java
@smalyshev smalyshev mentioned this pull request Jul 15, 2025
Merged
smalyshev added a commit to smalyshev/elasticsearch that referenced this pull request Jul 15, 2025
@smalyshev
Refactor and simplify missing index & unavailability handling (elasti…
1083d4a 
…c#131252)

(cherry picked from commit 366bc00)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java
@smalyshev
Copy link
Contributor Author

💔 Some backports could not be created

Status Branch Result
✅ 9.1
✅ 8.19
❌ 8.9 Conflict resolution was aborted by the user

Manual backport

To create the backport manually run:

backport --pr 131252

Questions ?

Please refer to the Backport tool documentation

@smalyshev smalyshev added v8.19.1 and removed v8.9.1 labels Jul 15, 2025
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
@smalyshev
Refactor and simplify missing index & unavailability handling (#131252)…
3a36a15 
… (#131304)

(cherry picked from commit 366bc00)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java
elasticsearchmachine pushed a commit that referenced this pull request Jul 15, 2025
@smalyshev
[8.19] Refactor and simplify missing index & unavailability handling (#…
1bc1890 
…131252) (#131305)

* Refactor and simplify missing index & unavailability handling (#131252)

(cherry picked from commit 366bc00)

# Conflicts:
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/session/EsqlSession.java

* add getClusterStates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged >non-issue >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.19.1 v9.1.0 v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smalyshev @elasticsearchmachine @dnhatn