Skip to content

Ignore human overloading error in xpack.info request #4944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Jul 17, 2025

See #4943 for details. I was initially going to remove the parameter, but then I got a new Request: missing json spec query parameter 'human' error, so I decided to ignore the error as it would have been done in eslint.

@pquentin pquentin requested a review from a team as a code owner July 17, 2025 11:46
@@ -54,10 +62,8 @@ export class ValidationErrors {
let count = 0
const logArray = function (errs: string[], prefix = ''): void {
for (const err of errs) {
if (err !== 'Missing request & response') {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer needed since #4031

Copy link
Contributor

Following you can find the validation changes against the target branch for the APIs.

No changes detected.

You can validate these APIs yourself by using the make validate target.

@pquentin pquentin merged commit b982f45 into main Jul 17, 2025
17 of 18 checks passed
@pquentin pquentin deleted the xpack-info-human-take-two branch July 17, 2025 12:56
github-actions bot pushed a commit that referenced this pull request Jul 17, 2025
github-actions bot pushed a commit that referenced this pull request Jul 17, 2025
github-actions bot pushed a commit that referenced this pull request Jul 17, 2025
github-actions bot pushed a commit that referenced this pull request Jul 17, 2025
pquentin added a commit that referenced this pull request Jul 17, 2025
(cherry picked from commit b982f45)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 17, 2025
(cherry picked from commit b982f45)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 17, 2025
(cherry picked from commit b982f45)

Co-authored-by: Quentin Pradet <[email protected]>
pquentin added a commit that referenced this pull request Jul 17, 2025
(cherry picked from commit b982f45)

Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants